Fix NULL dereference on allocation failure and validate invalid JSON Patch move operations#1045
Open
priyansx2233 wants to merge 3 commits into
Open
Fix NULL dereference on allocation failure and validate invalid JSON Patch move operations#1045priyansx2233 wants to merge 3 commits into
priyansx2233 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two critical issues in
cJSON_Utils.c:cJSON_malloc()fails in multiple public API code paths.moveoperations that attempt to move a value into one of its own descendants before any document mutation occurs.Changes
1. Handle allocation failures safely
Added missing
NULLchecks after calls tocJSON_malloc()in the following functions:compose_patch()create_patches()cJSONUtils_FindPointerFromObjectTo()On allocation failure, the functions now:
NULLpointer.2. Enforce RFC 6902 move validation
Added validation for JSON Patch
moveoperations to ensure the destination path is not the source path or one of its descendants, as required by RFC 6902 §4.4.The validation is performed before
detach_path()is called, preventing partial document modification when an invalid move operation is supplied.Benefits
NULL.cJSONUtils_FindPointerFromObjectTo().moveoperations comply with RFC 6902.moveoperations are processed.Testing
cJSON_malloc()fails.moveoperations where the destination is a descendant of the source, ensuring the patch is rejected and the original document remains unchanged.