fix: resolve strict TypeScript variant errors - #1042
Open
dinhnguyenminhhoang wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR resolves strict TypeScript typecheck failures across TS-CSS and TS-Tailwind component variants for AcidSquares, SpecularButton, and SplitText, aligning the variants with the repo’s strict TS configuration and addressing the errors described in #1041.
Changes:
- Fixes nullable/optional
RenderTargettyping and usage in AcidSquares variants. - Fixes nullable narrowing for the computed
targetangle in SpecularButton variants. - Fixes polymorphic tag + ref typing in SplitText variants by switching to an
HTMLElementref strategy.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ts-tailwind/TextAnimations/SplitText/SplitText.tsx | Adjusts polymorphic tag/ref typing to avoid never props and ref typing issues under strict TS. |
| src/ts-tailwind/Components/SpecularButton/SpecularButton.tsx | Tightens nullable narrowing for animation target angle selection. |
| src/ts-tailwind/Backgrounds/AcidSquares/AcidSquares.tsx | Updates RenderTarget lifecycle/typing to avoid null vs undefined strict TS errors. |
| src/ts-default/TextAnimations/SplitText/SplitText.tsx | Mirrors SplitText polymorphic ref typing fix in the default variant. |
| src/ts-default/Components/SpecularButton/SpecularButton.tsx | Mirrors SpecularButton nullable narrowing fix in the default variant. |
| src/ts-default/Backgrounds/AcidSquares/AcidSquares.tsx | Mirrors AcidSquares RenderTarget typing/lifecycle updates in the default variant. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1041
Summary
Validation
npm exec tsc -- --noEmit --pretty falsenpm exec vite build