Skip to content

fix: use 15 minute polling interval while SSE is connected #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieSinn merged 1 commit into from
Nov 5, 2026
Merged

fix: use 15 minute polling interval while SSE is connected #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devcycle_python_sdk/managers/config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(
self._options = options
self._local_bucketing = local_bucketing
self._sse_manager: Optional[SSEManager] = None
self._sse_polling_interval = 1000 * 60 * 15 * 60
self._sse_polling_interval = 1000 * 60 * 15 # 15 minutes
self._sse_connected = False
self._config: Optional[dict] = None
self._config_etag: Optional[str] = None
Expand Down
9 changes: 9 additions & 0 deletions test/managers/test_config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,15 @@ def test_init_with_client_callback_with_error(self, mock_get_config):
self.assertTrue(config_manager.is_initialized())
mock_callback.assert_called_once()

@patch("devcycle_python_sdk.api.config_client.ConfigAPIClient.get_config")
def test_sse_polling_interval_is_15_minutes(self, mock_get_config):
mock_get_config.return_value = (self.test_config_json, self.test_etag, None)
config_manager = EnvironmentConfigManager(
self.sdk_key, self.test_options, self.test_local_bucketing
)
self.assertEqual(config_manager._sse_polling_interval, 15 * 60 * 1000)
config_manager.close()

Comment on lines +113 to +121

@JamieSinn JamieSinn Nov 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test isn't needed

@patch("devcycle_python_sdk.api.config_client.ConfigAPIClient.get_config")
def test_close(self, mock_get_config):
mock_get_config.return_value = (self.test_config_json, self.test_etag)
Expand Down
Loading