Skip to content

Splitter: size of panes should be updated taking into account their limitations on splitter resize#32862

Merged
pharret31 merged 11 commits intoDevExpress:26_1from
pharret31:26_1_3660-splitter-size-of-panes-should-be-updated-taking-into-account-their-limitations-on-splitter-resize
Mar 30, 2026
Merged

Splitter: size of panes should be updated taking into account their limitations on splitter resize#32862
pharret31 merged 11 commits intoDevExpress:26_1from
pharret31:26_1_3660-splitter-size-of-panes-should-be-updated-taking-into-account-their-limitations-on-splitter-resize

Conversation

@pharret31
Copy link
Copy Markdown
Contributor

No description provided.

@pharret31 pharret31 self-assigned this Mar 11, 2026
@pharret31 pharret31 added the 26_1 label Mar 11, 2026
@pharret31 pharret31 marked this pull request as ready for review March 11, 2026 10:07
@pharret31 pharret31 requested a review from a team as a code owner March 11, 2026 10:07
Copilot AI review requested due to automatic review settings March 11, 2026 10:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Splitter’s dimension-change handling so pane sizes/layout are recalculated in a way that respects pane constraints (min/max/fixed sizes) when the splitter is resized, and expands the QUnit coverage for these scenarios.

Changes:

  • Reorders _dimensionChanged() to recalculate layout, apply it to DOM, then update stored item sizes.
  • Updates an existing resizing test expectation to match the new constraint-aware behavior.
  • Adds a set of new tests validating that minSize/maxSize constraints are respected after splitter width changes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/testing/tests/DevExpress.ui.widgets/splitter.tests.js Updates one existing resize test and adds new cases covering constraint enforcement after dimension changes.
packages/devextreme/js/__internal/ui/splitter/splitter.ts Changes dimension-change flow to apply the recalculated layout before persisting new pane sizes.

Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Copilot AI review requested due to automatic review settings March 18, 2026 11:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts Outdated
@pharret31 pharret31 force-pushed the 26_1_3660-splitter-size-of-panes-should-be-updated-taking-into-account-their-limitations-on-splitter-resize branch from cac954d to 49bbb53 Compare March 26, 2026 17:55
Copilot AI review requested due to automatic review settings March 27, 2026 11:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Copilot AI review requested due to automatic review settings March 30, 2026 09:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Copilot AI review requested due to automatic review settings March 30, 2026 10:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Copilot AI review requested due to automatic review settings March 30, 2026 12:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/ui/splitter/splitter.ts:692

  • _initialPaneSizes is only captured during _renderItems(). If a consumer sets items[i].size at runtime (especially for a resizable: false pane), the new explicit size won't be reflected in _initialPaneSizes, so subsequent dimension changes may treat it as "no explicit size" and allow it to scale. Consider updating _initialPaneSizes[index] when handling the 'size' item option change so runtime updates behave consistently.
    switch (property) {
      case 'size':
        this._layout = this._getDefaultLayoutBasedOnSize(item);
        this._idealLayout = this._layout;

        this._applyStylesFromLayout(this.getLayout());
        this._updateItemSizes();
        break;

Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
Comment thread packages/devextreme/js/__internal/ui/splitter/splitter.ts
@pharret31 pharret31 merged commit b60da63 into DevExpress:26_1 Mar 30, 2026
130 of 132 checks passed
@pharret31 pharret31 deleted the 26_1_3660-splitter-size-of-panes-should-be-updated-taking-into-account-their-limitations-on-splitter-resize branch March 30, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants