T1329805: DataGrid — Scrolling does not work when hovering over a cell containing a web component#34113
Open
Raushen wants to merge 1 commit into
Open
T1329805: DataGrid — Scrolling does not work when hovering over a cell containing a web component#34113Raushen wants to merge 1 commit into
Raushen wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DataGrid scrolling when the pointer is over content rendered inside a Web Component (Shadow DOM) by ensuring DevExtreme’s gesture emitter lookup can traverse out of a shadow tree to find emitters attached on ancestor elements.
Changes:
- Updated
EventManager._closestEmittertraversal to walk via DOM parent nodes with Shadow DOM host fallback (instead of renderer/jQuery.parent()). - Added
getParentNodeDOM utility to support walking from a shadow root to its host. - Added Jest coverage validating
dxscrollinitis triggered when wheel events originate from both regular descendants and Shadow DOM descendants.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/devextreme/js/__internal/events/core/m_emitter_registrator.ts | Reworks emitter lookup to traverse parent nodes across Shadow DOM boundaries. |
| packages/devextreme/js/__internal/events/core/tests/emitter_registrator.test.ts | Adds regression tests for gesture emitter lookup with Shadow DOM wheel targets. |
| packages/devextreme/js/__internal/core/utils/m_dom.ts | Introduces getParentNode utility and exports it for reuse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.