Repository navigation
Ask for confirmation before uninstalling packages - #5533
Open
Maxime Landry (mlandry-devolutions) wants to merge 2 commits into
Open
Maxime Landry (mlandry-devolutions) wants to merge 2 commits into
Maxime Landry (mlandry-devolutions) wants to merge 2 commits into
Conversation
…d and Updates pages Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd the uninstall options dialog Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Maxime Landry (mlandry-devolutions)
requested review from
Gabriel Dufresne (GabrielDuf)
and
a balanced review from Copilot
October 16, 2026 18:25
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking issues in confirmation routing, cancellation handling, or existing caller integration.
0 open findings
What changed in this PR
Adds confirmation before uninstalling packages through the desktop UI, reusing the existing translated confirmation dialog.
Changes:
- Routes Installed and Updates page uninstall actions through confirmation.
- Confirms package-details uninstall actions while keeping details open when declined.
- Preserves catalog confirmation without adding duplicate prompts.
| File | Description |
|---|---|
src/UniGetUI.Avalonia/Views/SoftwarePages/SoftwareUpdatesPage.cs |
Confirms selected packages before uninstalling. |
src/UniGetUI.Avalonia/Views/SoftwarePages/InstalledPackagesPage.cs |
Adds shared confirmation routing for uninstall entry points. |
src/UniGetUI.Avalonia/Views/DialogPages/PackageDetailsWindow.axaml.cs |
Confirms primary and variant uninstall actions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UninstallConfirmationDialogalready exists (translated, with the package list), but only the Software Catalog called it: every other uninstall started right away. On the Updates page every row is checked by default, so a single click on "Uninstall selected packages" uninstalled every package with an update.ConfirmAndLaunchUninstall.LaunchUninstallFromUpdates.LaunchUninstall, because the catalog confirms before calling it.No new string. Left as is: "Uninstall then reinstall" (reinstalls right after), repeating an operation from the history, and the IPC API.
Tested on macOS: Installed and Updates pages, context menu, package details and its variants; No cancels everywhere and nothing is uninstalled.
Relates to UNI-37
🤖 Generated with Claude Code