Skip to content

ci: run timing-sensitive tests serially - #1987

Merged
Benoît Cortier (CBenoit) merged 3 commits into
masterfrom
cbenoit-timing-sensitive-ci
Sep 15, 2026
Merged

Benoît Cortier (CBenoit) merged 3 commits into
masterfrom
cbenoit-timing-sensitive-ci

Conversation

@CBenoit

Copy link
Copy Markdown
Member

Run the ignored timing tests separately on Linux and Windows so timing-sensitive regressions remain covered without competing with parallel integration tests.

Run the ignored timing tests separately on Linux and Windows so timing-sensitive regressions remain covered without competing with parallel integration tests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 15, 2026 15:37
@CBenoit

Benoît Cortier (CBenoit) commented Sep 15, 2026

Copy link
Copy Markdown
Member Author

Implementation notes:

  • Runs the existing ignored timing:: namespace as a separate step in the Linux and Windows test matrix.
  • Forces one test thread so concurrent integration tests cannot distort the timing budget.
  • Reuses the main test step's platform-targeted artifacts and preserves the locked dependency graph and AWS-LC no-assembly setting.

Validation:

  • cargo test --locked --target x86_64-pc-windows-msvc -p testsuite --test integration_tests timing:: -- --ignored --test-threads=1

Note

LLM-assisted content (no human feedback).

Use a YAML block scalar so the timing namespace filter is parsed as a shell command rather than a mapping.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new command omits the existing target triple and unnecessarily recompiles test artifacts.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds a serial CI step for ignored timing-sensitive tests on Linux and Windows.

Changes:

  • Runs timing:: integration tests with one test thread.

External-contract, documentation, and prose reviews were not applicable.

File summaries
File Description
.github/workflows/ci.yml Adds the timing-sensitive test step.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml Outdated
Pass the platform target triple to the serial timing test command so it reuses artifacts built by the main test step.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused CI change correctly isolates timing-sensitive tests and reuses target-specific artifacts.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@CBenoit
Benoît Cortier (CBenoit) merged commit d481b23 into master Sep 15, 2026
87 of 89 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the cbenoit-timing-sensitive-ci branch September 15, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants