Skip to content

Expand portable Artifact Signing parity#15

Merged
Marc-André Moreau (mamoreau-devolutions) merged 3 commits into
masterfrom
mamoreau-devolutions/artifact-signing-review
May 25, 2026
Merged

Expand portable Artifact Signing parity#15
Marc-André Moreau (mamoreau-devolutions) merged 3 commits into
masterfrom
mamoreau-devolutions/artifact-signing-review

Conversation

@mamoreau-devolutions
Copy link
Copy Markdown
Contributor

@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) commented May 25, 2026

Summary

  • add portable Artifact Signing remote-sign embedding for CAB, MSI/MSP, generic catalogs, and flat MSIX/AppX final signing
  • add native-shaped portable batch ergonomics, expanded credential resolution, and non-PE timestamp persistence
  • incorporate #16 by propagating code-mode RFC3161 timestamp options into PE/WinMD signing
  • update docs and integration tests for the expanded replacement surface

Validation

  • cargo fmt --all
  • cargo clippy --workspace --all-targets --locked
  • cargo test --workspace --locked
  • targeted Artifact Signing integration tests
  • targeted code-mode RFC3161 timestamp regression tests from Fix PE RFC3161 timestamps in code mode #16

Add portable Artifact Signing support for CAB/MSI/catalog remote embedding, native-shaped batch ergonomics, credential parity, timestamping, and flat MSIX/AppX final signing. Update docs and integration coverage for the expanded replacement surface.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move glob and rayon into cross-platform root dependencies because portable signing now uses batch expansion and parallel execution outside Windows. Keep the Artifact Signing credential enum available when portable CLI option structs compile without the REST feature.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Propagate code-mode RFC3161 timestamp options into PE/WinMD signing so top-level PE targets and nested PE payloads inside signed containers receive Microsoft Authenticode timestamp attributes. Add regression coverage for top-level PE timestamping and for nested DLLs inside a .nupkg.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) merged commit ca1b678 into master May 25, 2026
36 checks passed
@mamoreau-devolutions Marc-André Moreau (mamoreau-devolutions) deleted the mamoreau-devolutions/artifact-signing-review branch May 25, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants