fix: improve default error handling #1379 #1409 by Alexj9837 · Pull Request #1439 · DiamondLightSource/blueapi

Alexj9837 · 2026-03-10T14:19:53Z

Both issues related to error handling in the REST client.

1379 - Catches 'UnauthorisedAccessErrorexplicitly instead of string-matching onBlueskyRemoteControlError`.

1409 - Expands the exception hierarchy so each
HTTP status code raises a distinct typed exception rather than bundling
everything into BlueskyRemoteControlError.

Tests

Update tests to match new exception signatures
Add missing coverage for 422 non-list detail response
Add missing coverage for streaming error in run command

codecov · 2026-03-10T14:27:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.26%. Comparing base (e7eae6c) to head (f33a736).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
+ Coverage   95.19%   95.26%   +0.07%     
==========================================
  Files          43       43              
  Lines        3119     3125       +6     
==========================================
+ Hits         2969     2977       +8     
+ Misses        150      148       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/blueapi/client/rest.py

tests/system_tests/test_blueapi_system.py

tests/unit_tests/cli/test_cli.py

tests/unit_tests/client/test_rest.py

ZohebShaikh

Looks good only few things can be tidied up

tpoliaw · 2026-04-10T15:05:25Z

src/blueapi/cli/cli.py

    except UnauthorisedAccessError as ua:
        raise ClickException("Unauthorised request") from ua


I think this will prevent your new check_connection changes having an effect when running plans - you'll still get the Unauthorised request message

src/blueapi/cli/cli.py

tpoliaw · 2026-04-10T15:20:00Z

tests/system_tests/test_blueapi_system.py

    with pytest.raises(BlueskyRemoteControlError) as exception:
        client.resume()
-    assert "<Response [400]>" in str(exception)
+    assert exception.value.args[0]


What are these asserts testing for?

Poor grammar. Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>

Alexj9837 self-assigned this Mar 10, 2026

Alexj9837 force-pushed the chore/improve-default-error-handling-1379-1409 branch from accdd8c to c5ab6b3 Compare March 10, 2026 14:20

Alexj9837 force-pushed the chore/improve-default-error-handling-1379-1409 branch from c5ab6b3 to 883b09e Compare March 11, 2026 09:39

Alexj9837 removed their assignment Mar 11, 2026

Alexj9837 force-pushed the chore/improve-default-error-handling-1379-1409 branch from 883b09e to 05150ae Compare March 11, 2026 11:06