Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
==========================================
+ Coverage 96.46% 96.48% +0.01%
==========================================
Files 49 49
Lines 3791 3811 +20
==========================================
+ Hits 3657 3677 +20
Misses 134 134 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Alexj9837
force-pushed
the
register-child-devices-on-top
branch
from
November 3, 2026 08:35
b4975f8 to
e7797e3
Compare
Alexj9837
force-pushed
the
register-child-devices-on-top
branch
from
November 3, 2026 08:36
e7797e3 to
396a673
Compare
Alexj9837
force-pushed
the
register-child-devices-on-top
branch
from
November 3, 2026 09:10
9fd0086 to
8ee7db7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1724
Registering an ophyd-async device now also registers its children, including signals, under their own names at any depth (
stagealso givesstage-x,stage-x-velocityetc). Dotted access still works. Ophyd v1 devices are left alone.Name clashes:
<parent>-<attribute>(motor-user_readback)./devicesreports each device under its registered name so the two don't both show up asmotorstage-xbeforestage, thenstage.xand its children are skipped with a warning, rather than adding astage-x-positionthat looks like it belongs to the wrong deviceThings to note:
/devicesand the plan schemas get a lot bigger (adsim goes from 2 to 119 devices), and low level signals like setpoints now show up as plan argument options, hence the system test JSON diff. This needs a follow up ticket.bank-axes-1). The dotted form (bank.axes.1) still doesn't work, as beforeMock(spec=Device)will now fail, use a realDevice