Fix indexing and calculated indexes only when buffer changes#156
Open
LeandroMartinsdS wants to merge 1 commit intodls-masterfrom
Open
Fix indexing and calculated indexes only when buffer changes#156LeandroMartinsdS wants to merge 1 commit intodls-masterfrom
LeandroMartinsdS wants to merge 1 commit intodls-masterfrom
Conversation
LeandroMartinsdS
force-pushed
the
fix_ppmac_trajScan
branch
from
35214b1 to
fb4b3a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes indexing bug from A_idx, where positions and velocities were getting falling behind, as their indexes were getting non integer values, making them to increment just once every 2 points.
Also, calculates the base indexes only when the
CurrentBufferAdrchanges, avoiding unnecessary calculations for each point