This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Patch entity networking#37
Open
UpcraftLP wants to merge 10 commits intoDimensionalDevelopment:masterfrom
Open
Conversation
ChloeDawn
suggested changes
Oct 7, 2018
| maven { url 'https://libraries.minecraft.net/' } | ||
| maven { url 'https://www.dimdev.org/maven/' } | ||
| maven { url = 'https://repo.spongepowered.org/maven/' } | ||
| maven { |
Contributor
There was a problem hiding this comment.
Redundant formatting change
| main | ||
| debug { | ||
| compileClasspath += main.compileClasspath | ||
| compileClasspath += main.compileClasspath + main.output |
| @Shadow @Final private ClientSuggestionProvider clientSuggestionProvider; | ||
| @Shadow private NetworkTagManager networkTagManager; | ||
| @Shadow private NBTQueryManager nbtQueryManager; | ||
| @Shadow |
Contributor
There was a problem hiding this comment.
Redundant formatting change
| for (CustomPayloadHandler customPayloadHandler : RiftLoader.instance.getListeners(CustomPayloadHandler.class)) { | ||
| if (customPayloadHandler.clientHandlesChannel(channelName)) { | ||
| for(CustomPayloadHandler customPayloadHandler : RiftLoader.instance.getListeners(CustomPayloadHandler.class)) { | ||
| if(customPayloadHandler.clientHandlesChannel(channelName)) { |
Contributor
There was a problem hiding this comment.
Redundant formatting change
|
|
||
| Class<? extends Message> messageClass = Message.REGISTRY.get(channelName); | ||
| if (messageClass != null) { | ||
| if(messageClass != null) { |
Contributor
There was a problem hiding this comment.
Redundant formatting change
| private void handleUpdateModTileEntity(SPacketUpdateTileEntity packet, CallbackInfo ci) { | ||
| TileEntity tileEntity = world.getTileEntity(packet.getPos()); | ||
| if (tileEntity == null || packet.getNbtCompound() == null || !packet.getNbtCompound().hasKey("id", 8)) { | ||
| if(tileEntity == null || packet.getNbtCompound() == null || !packet.getNbtCompound().hasKey("id", 8)) { |
Contributor
There was a problem hiding this comment.
Redundant formatting change
| method.setAccessible(true); | ||
| addURLHandle = MethodHandles.lookup().unreflect(method); | ||
| } catch (ReflectiveOperationException e) { | ||
| } catch(ReflectiveOperationException e) { |
Contributor
There was a problem hiding this comment.
Redundant formatting change
| //noinspection unchecked | ||
| return (T) MethodHandles.lookup().unreflectConstructor(constructor).invokeWithArguments(constructorArgs); | ||
| } catch (Throwable t) { | ||
| } catch(Throwable t) { |
Contributor
There was a problem hiding this comment.
Redundant formatting change
| try { | ||
| addURLHandle.invoke(ClassLoader.getSystemClassLoader(), url); | ||
| } catch (Throwable t) { | ||
| } catch(Throwable t) { |
Contributor
There was a problem hiding this comment.
Redundant formatting change
| "package": "org.dimdev.rift.mixin.hook", | ||
| "refmap": "mixins.rift.refmap.json", | ||
| "mixins": [ | ||
| "MixinAnvilSaveHandler", |
Contributor
There was a problem hiding this comment.
These do not need resorting entirely, new mixins can just be appended
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.