Conversation
Replace many individual label props with a single labels object passed from App to Static. Update Static to read labels from props.labels, simplify setLabels in App, and update defaultProps/propTypes accordingly. Add UI and handlers for a restart message and a reset button shown after importing settings (showRestartMessage/hideRestartMessage/resetSettings) and clear the file input after import. Add related CSS for import row, reset button, and restart message, and tweak bottomMenu classes in App.css.
There was a problem hiding this comment.
Pull request overview
This PR restructures label management in the Static component and adds a reset functionality for imported settings. When users import settings, they now see a restart message and can reset to defaults via a new button.
Changes:
- Consolidated individual label props into a single
labelsobject for improved organization - Added reset button next to Import Settings that appears after settings import
- Implemented restart message display after settings are imported
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Static.js | Refactored props to use labels object, added reset button/message functionality with window methods |
| src/Static.css | Added styling for reset button, restart message animation, and grid layout adjustments |
| src/App.js | Updated to pass consolidated labels object instead of individual props |
| src/App.css | Modified bottom menu height styling to accommodate new UI elements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@hwahlstrom any suggestions on the message and the UX here for the message and the reset button, I intentionally made the message smaller to have it fit below the button. |
|
@zeusongit I would recommend a toast for a few reasons:
But let me know if a toast is not feasible and I can propose an alternative solution. 
|
Thanks for the suggestion, and will work on it and let you know more regarding it's feasibility. |
Introduce a reusable Toast notification (src/Toast.js + src/Toast.css) and unit tests (tests/Toast.test.js). Integrate the Toast into App (src/App.js) and add a debug-mode detection that auto-loads Static when WebView2 is not present and shows a small "Debug Mode" label. Update Static (src/Static.js, src/Static.css) to: use safer typeof checks for chrome.webview, remove the inline restart message UI/CSS in favor of showing toasts via window.showToast/window.hideToast, and mock import callbacks when running outside WebView2 for local development. Update package.json to include the new Toast test in test:unit. These changes enable in-app notifications and improve local dev/debug behavior without WebView2.
@hwahlstrom please take another look, updated now |
RobertGlobant20
left a comment
RobertGlobant20
left a comment
There was a problem hiding this comment.
Looks good to me with two comments
3 participants
In this PR:
Resetbutton next to Import Settings when new settings are imported, to reset to default state.Should be merged before DynamoDS/Dynamo#16878
Screen.Recording.2026-02-09.183435.mp4
Old Implementation
Screen.Recording.2026-02-05.191906.mp4