Conversation
- only create xmldsig framgnets which are listed (like other fragments) - remove unused fields for optimization (per default remove "shall not be used" from standard) removed elements are not in structure and will result in en/decoder error NOT_IMPLEMENTED when "isUsed" flag is set. Signed-off-by: Michael Mezger <michael.mezger@chargebyte.com>
|
The change is not optimal. |
|
Notes for us when reviewing this:
|
|
For the record, from my experiments:
Our regression tests seem to pass. |
|
If we take this in, we should also do the same optimizations for DIN and ISO 15118-20. Applied to DIN and ISO -20: With a modified version of this PR, rebased on HEAD: |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
🟢 Metrics 27 complexity · -2 duplication
Metric Results Complexity 27 Duplication -2
TIP This summary will be updated as you push new changes. Give us feedback
Remove optimization flags from default config and only add them as comments. Remove "illegal" characters from comments. Signed-off-by: Michael Mezger <michael.mezger@chargebyte.com>
Describe your changes
removed elements are not in structure and will result in en/decoder error NOT_IMPLEMENTED when "isUsed" flag is set or element is accessed in decoder.
Issue ticket number and link
Feature request #75
Checklist before requesting a review