Skip to content

Conversation

@WeihanLi
Copy link
Contributor

@WeihanLi WeihanLi commented Dec 9, 2025

This pull request updates the project to target .NET 10.0 across all main components, including CI workflows and project files. It also refines package references for compatibility and removes obsolete code that was previously required for older .NET versions.

.NET version upgrade:

  • Updated all relevant project files (EasyNetQ.Management.Client.csproj, EasyNetQ.Management.Client.Tests.csproj, EasyNetQ.Management.Client.IntegrationTests.csproj, EasyNetQ.Management.Client.ApprovalTests.csproj) to target .NET 10.0 instead of .NET 8.0, ensuring the codebase uses the latest .NET features and APIs. [1] [2] [3] [4]
  • Modified CI workflow (.github/workflows/ci.yml) to use .NET SDK 10.x and set the test matrix to run against net10.0. [1] [2] [3] [4] [5]

Package reference improvements:

  • Updated the System.Text.Json package reference in EasyNetQ.Management.Client.Tests.csproj to only be included for net48, preventing unnecessary inclusion for newer .NET versions.

Code cleanup for compatibility:

  • Removed the JsonNumberEnumConverter implementation for older .NET versions, as it is no longer needed with the upgrade to .NET 10.0.

@inikulshin
Copy link
Contributor

Imo, the condition

#if !NET8_0_OR_GREATER && !NETSTANDARD2_0

made JsonNumberEnumConverter to be used for .NET Framework


<PropertyGroup>
<TargetFrameworks>netstandard2.0;net6.0;net8.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net10.0;net8.0</TargetFrameworks>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<TargetFrameworks>netstandard2.0;net10.0;net8.0</TargetFrameworks>
<TargetFrameworks>netstandard2.0;net8.0;net10.0</TargetFrameworks>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But honestly I don't think that new tfm is needed. Are there any new apis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants