Stop Promise.allSettled from being stomped
#5938
Open
+74
−1,119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
swansontec
force-pushed
the
william/all-settled-error
branch
2 times, most recently
from
61f78c8 to
e6e3520
Compare
swansontec
changed the title
Promise.allSettled with fuzzyTimeoutPromise.allSettled from being stomped
This old library was stomping on our Promise implementation, removing modern methods we rely on. A recent Hermes change seems to have triggered this behavior (`Promise.resolve().toString` is returning '[object Object]' instead of '[object Promise]'), so this just started happening. Upgrade to a more modern edition of the ParaSwap SDK.
swansontec
force-pushed
the
william/all-settled-error
branch
from
e6e3520 to
fad2e19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function does not exist in the Hermes runtime, but our fuzzyTimeout is similar enough (and has the extra benefit of ignoring promises that take much too long).
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Touches the Aave close-with-collateral path that builds ParaSwap routes/transactions, so any SDK behavioral differences could affect repay execution despite being a mostly mechanical dependency migration.
Overview
Updates the Aave borrow plugin to use
@paraswap/sdkinstead of the legacyparaswappackage, including adaptingParaSwapconstruction to the new options-object API.Also tightens TypeScript typing in
AaveBorrowEngineFactory(explicit return types,unknownincatch) and refreshes lint config to stop special-casing that file. Dependency lockfile changes reflect the ParaSwap SDK upgrade and removal of the old ParaSwap/Web3-related transitive packages.Written by Cursor Bugbot for commit fad2e19. This will update automatically on new commits. Configure here.