Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 1d94a64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect.txreruns its body in a tight loop, using a full CPU core, when the body recovers fromEffect.txRetryinstead of letting it propagate. The documented behavior is that a retry waits until a transactional value the body read changes. A common way to hit it is observing a blocking Tx operation inside a larger transaction, for exampleEffect.tx(Effect.exit(TxQueue.take(queue)))on an empty queue, orEffect.ignoreCause(TxSemaphore.acquire(sem)).txRetrymarks the transaction for retry and fails the body with an interrupt cause. The wait for a change,awaitPendingTransaction, only runs in thetapCauseon the failure path. When the body turns that cause into a success,stepstill sees the retry flag, discards the result and reruns at once without waiting. This adds the same interruptible wait on the success path, so a recovered retry parks until a read value changes, as an unrecovered one already does. The failure path from #8780 is unchanged. Interrupting a transaction parked this way rolls back its writes and removes its waiters, like the existing path. A recovered retry still never commits its attempt; it only stops spinning.Verification
Attempts made by a transaction blocked for 300 ms, on
effect@4.1.4(same onmain):On this branch, with the same final results:
The two new tests in
Effect.test.tscover waiting after a recovered retry and interrupting the parked transaction; both fail without the change.pnpm check,pnpm lintand theeffecttest project pass locally, apart from three Bash completion tests that also fail onmainin my environment.