Open
Conversation
adi2011
force-pushed
the
attributable-errors
branch
from
3e1927f to
5368e11
Compare
Collaborator
|
Hi @adi2011 I'm wondering if you are planning on returning to this work? :) |
Collaborator
Author
|
Hi @madelinevibes, I am planning to work on all my PRs for this upcoming release. :) |
Collaborator
excellent!
|
Adding the optional TLVs to update_fail_htlc, update_fulfill_htlc and struct onionreply so that we can parse and store it. Key Changes: - Add tlvtype 'attribution_data' to 'update_fail_htlc' and 'update_fulfill_htlc' msgtype. - Add 'htlc_hold_time' & 'truncated_hmac' to struct onionreply.
We initialise time of creating htlc_out and calculate the time when this htlc_out is failed. Key Changes: - Add 'send_timestamp' to htlc_out. - Calculate hold_time when htlc_out is failed.
Implemented methods to wrap attribution data, update the attribution data. Key Changes: - Use 'ammagext' subkey to crypt the attr data. - Write method to add HMACs to the attr data. - Update attribution data to a given onionreply. - Write method to verify attr data to find erring node. - Use all these helpers inside unwrap_onionreply().
Sending attr data while sending update_fail_htlc and processing the attr data when received a update_fail_htlc msg. Key Changes: - Serializing updated attr data inside send_fail_or_fulfill. - Deserializing and processing the TLVs while parsing recvd update_fail_htlc msg.
This is required to send attribution data from channeld to lightningd. Key Changes: - Add attribution_data to fulfilled_htlc and htlc - Modify fromwire/towire_fulfilled_htlc to accommodate the change - Make channeld handle attribution data
Key Changes: - Add fulfill_onion to htlc_in, this would include the wrapped attribution data - Add attribution_data to htlc_out, we store the incoming attr data here
Key changes: - Add test to check correct serialization and deserialization of attr data inside onionreply.
adi2011
force-pushed
the
attributable-errors
branch
from
5368e11 to
eaca46a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attributable errors: lightning/bolts#1044
Still a bit rough — needs comments, a flow polish, and maybe a cup of coffee. Hoping for an approach ACK, especially based on run-sphinx.c.
Addresses: #8153