Remove watch txids and make watches more bwatch-like: part 1#8927

Draft

rustyrussell wants to merge 24 commits intoElementsProject:masterfrom

rustyrussell:guilt/remove-watch_txid

Commits on Mar 5, 2026

CCAN: import version with htable_lock.
rustyrussell
committed
lightningd: use htable lock/unlock to ensure we don't add to htables while iterating.
rustyrussell
committed
lightningd: remove redundant `txid` arg in depthcb_update_scid.
rustyrussell
committed
tx: make bitcoin_tx_output_get_amount_sat() return amount_sat.
rustyrussell
committed
lightningd: make caller to deptch_update_scid fetch the location in the block
rustyrussell
committed
lightningd: bail out on splice if scid doesn't fit.
rustyrussell
committed
lightningd: use inflight->locked_scid instead of db lookup when splice locked.
rustyrussell
committed
lightningd: fix type of splice_depth_cb, remove never-working splice_inflight_txwatch.
rustyrussell
committed
lightningd: make wallet_extract_owned_outputs return bool, optionally output numbers.
rustyrussell
committed
chaintopology: don't use txfilter, rely on wallet_extract_owned_outputs.
rustyrussell
committed
wallet: remove txfilter.
rustyrussell
committed
bitcoin: hoist script_with_len out of wallet/ into here.
rustyrussell
committed
patch encode_scriptpubkey_to_addr-len.patch
rustyrussell
committed
lightningd: add generic scriptpubkey watches.
rustyrussell
committed
lightningd: support watch-for-blockdepth primitive.
rustyrussell
committed
lightningd: use scriptpubkey, not watch_txid for initial spotting of the funding tx.
rustyrussell
committed
lightningd: split out separate function for "depth == 0".
rustyrussell
committed
lightningd: use a blockdepth callback instead of a watch_txid.
rustyrussell
committed
lightningd: explicitly unwatch funding scriptpubkey when channel finally closed.
rustyrussell
committed
lightningd: make dualopend's opening_depth_cb use depthcb_update_scid.
rustyrussell
committed
lightningd: use scriptpubkey and blockdepth watches instead of tx watches for dual funding.
rustyrussell
committed
lightningd: use scriptpubkey watch and block depth watch for splicing.
rustyrussell
committed
lightningd: save short_channel_id in inflight struct as soon as it gets mined.
rustyrussell
committed
lightningd: use scriptpubkey watches not txid watches for inflights on closing.
rustyrussell
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove watch txids and make watches more bwatch-like: part 1#8927

Remove watch txids and make watches more bwatch-like: part 1#8927
rustyrussell wants to merge 24 commits intoElementsProject:masterfrom
rustyrussell:guilt/remove-watch_txid

Commits on Mar 5, 2026

CCAN: import version with htable_lock.

lightningd: use htable lock/unlock to ensure we don't add to htables while iterating.

lightningd: remove redundant `txid` arg in depthcb_update_scid.

tx: make bitcoin_tx_output_get_amount_sat() return amount_sat.

lightningd: make caller to deptch_update_scid fetch the location in the block

lightningd: bail out on splice if scid doesn't fit.

lightningd: use inflight->locked_scid instead of db lookup when splice locked.

lightningd: fix type of splice_depth_cb, remove never-working splice_inflight_txwatch.

lightningd: make wallet_extract_owned_outputs return bool, optionally output numbers.

chaintopology: don't use txfilter, rely on wallet_extract_owned_outputs.

wallet: remove txfilter.

bitcoin: hoist script_with_len out of wallet/ into here.

patch encode_scriptpubkey_to_addr-len.patch

lightningd: add generic scriptpubkey watches.

lightningd: support watch-for-blockdepth primitive.

lightningd: use scriptpubkey, not watch_txid for initial spotting of the funding tx.

lightningd: split out separate function for "depth == 0".

lightningd: use a blockdepth callback instead of a watch_txid.

lightningd: explicitly unwatch funding scriptpubkey when channel finally closed.

lightningd: make dualopend's opening_depth_cb use depthcb_update_scid.

lightningd: use scriptpubkey and blockdepth watches instead of tx watches for dual funding.

lightningd: use scriptpubkey watch and block depth watch for splicing.

lightningd: save short_channel_id in inflight struct as soon as it gets mined.

lightningd: use scriptpubkey watches not txid watches for inflights on closing.