Openchannel and bcli unneeded code - #9418
Open
rustyrussell wants to merge 2 commits into
Open
Conversation
…gate for getblockfrompeer. Minimum version for bitcoind in CI is 25.0, but elements is older. Bump hard reject version to 23.0 (which elements will still pass, just). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This triggered a false positive use-after-free issue from Red Team. In fact, the children of new_node_copy are deliberately owned by clone already (see f246896) so this cleanup attempt (which was wrong, since size_t is never "> -1") was unnecessary anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minimum BTC according to CI is 25.0, but elements is still 23, so we can't bump this version further. And 25.0 is out of support anyway!
Changelog-None