Reset DepthStencilState to None before Skybox.Draw#1083
Reset DepthStencilState to None before Skybox.Draw#1083maddie480 merged 2 commits intoEverestAPI:devfrom
DepthStencilState to None before Skybox.Draw#1083Conversation
There was a problem hiding this comment.
Disclaimer: I could not reproduce the issue on my end, so I could not check if the changes actually fixes the issue; however the mountain and skybox render correctly with this change.
Edit: I was able to reproduce the issue, and confirms the change fixes the issue.
I approve with minor nitpicks left in comments.
I'm on Everest |
Sorry, I must have made a mistake when testing previously, I was able to reproduce the issue, and confirm the PR fixes it. |
|
The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further. |
|
The last-call window for this pull request ended. It can now be merged if no blockers were brought up. |
Skybox.Drawdoesn't resetDepthStencilStatetoNone. Some mods may begin a newSpriteBatchwithDepthStencilStateset toDefault(such asCelesteTAS), which causes theSkyboxto be rendered in front of the mountain.This pr resets
DepthStencilStatetoNonebeforeSkybox.Draw.Special thanks to @Qingfeng-UwU for identifying this issue.