Skip to content

Reset DepthStencilState to None before Skybox.Draw#1083

Merged
maddie480 merged 2 commits intoEverestAPI:devfrom
Saplonily:fix-skybox
Mar 8, 2026
Merged

Reset DepthStencilState to None before Skybox.Draw#1083
maddie480 merged 2 commits intoEverestAPI:devfrom
Saplonily:fix-skybox

Conversation

@Saplonily
Copy link
Contributor

Skybox.Draw doesn't reset DepthStencilState to None. Some mods may begin a new SpriteBatch with DepthStencilState set to Default(such as CelesteTAS), which causes the Skybox to be rendered in front of the mountain.
This pr resets DepthStencilState to None before Skybox.Draw.
Special thanks to @Qingfeng-UwU for identifying this issue.

Copy link
Member

@microlith57 microlith57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@maddie480-bot maddie480-bot added the 1: review needed This PR needs 2 approvals to be merged (bot-managed) label Feb 4, 2026
Copy link
Contributor

@DashingCat DashingCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: I could not reproduce the issue on my end, so I could not check if the changes actually fixes the issue; however the mountain and skybox render correctly with this change.
Edit: I was able to reproduce the issue, and confirms the change fixes the issue.

I approve with minor nitpicks left in comments.

@Saplonily
Copy link
Contributor Author

Disclaimer: I could not reproduce the issue on my end, so I could not check if the changes actually fixes the issue; however the mountain and skybox render correctly with this change.

I approve with minor nitpicks left in comments.

I'm on Everest 0e2f7db9 - (dev) Merge pull request #1075 from DashingCat/patch-1, CelesteTAS v3.47.0 and StrawberryJam2021 v1.0.12, and reproduced it by watching SJ's mountains 🤔

@DashingCat
Copy link
Contributor

I'm on Everest 0e2f7db9 - (dev) Merge pull request #1075 from DashingCat/patch-1, CelesteTAS v3.47.0 and StrawberryJam2021 v1.0.12, and reproduced it by watching SJ's mountains 🤔

Sorry, I must have made a mistake when testing previously, I was able to reproduce the issue, and confirm the PR fixes it.

@maddie480-bot
Copy link
Member

The pull request was approved and entered the 3-day last-call window. Since no PR should be merged within 3 days of the next rolling release, the last-call window is extended further.
If no further reviews happen, it will end on Mar 8, 2026, 12:00 AM UTC, after which the pull request will be able to be merged.

@maddie480-bot maddie480-bot added 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) and removed 1: review needed This PR needs 2 approvals to be merged (bot-managed) labels Mar 1, 2026
@maddie480-bot
Copy link
Member

The last-call window for this pull request ended. It can now be merged if no blockers were brought up.

@maddie480-bot maddie480-bot added 4: ready to merge This PR was approved and the last-call window is over (bot-managed) and removed 3: last call window This PR was approved, and is in the 5-day last-call window before getting merged (bot-managed) labels Mar 8, 2026
@maddie480 maddie480 merged commit bffed34 into EverestAPI:dev Mar 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: ready to merge This PR was approved and the last-call window is over (bot-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants