Skip to content

Rename "Export current view" option and standardize export filenames#94083

Draft
rlinoz wants to merge 4 commits into
mainfrom
rodrigo-export-current-view-94056
Draft

Rename "Export current view" option and standardize export filenames#94083
rlinoz wants to merge 4 commits into
mainfrom
rodrigo-export-current-view-94056

Conversation

@rlinoz

@rlinoz rlinoz commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Two changes from the linked issue:

  1. Renames the export menu option "Export current view" → "Current view" (en + es). The user already clicks an Export button to open this menu, so the leading "Export" was redundant.
  2. Standardizes export filenames. All NewDot Search CSV exports now produce a consistent Expensify_<exportName>_<uniqueID>.csv name, where <exportName> is the UI label (e.g. "Current view", "Basic export"). The date/time suffix is dropped (the OS already records download time); a unique id prevents collisions.

To do this:

  • A new helper getExportFileName(exportName, uniqueID, extension) builds the standardized name.
  • fileDownload gains an opt-out appendTimestamp flag (default true, so all other downloads — attachments, receipts, statements, QR codes — keep their timestamp); the export flows pass false.
  • The UI export label is threaded as a new exportName param through exportSearchItemsToCSV, queueExportSearchItemsToCSV, and queueExportSearchWithTemplate, plus every caller in the Search and report-header export menus.

The async/Concierge and template exports are named on the backend; see the companion PR: https://github.com/Expensify/Web-Expensify/pull/53872

Fixed Issues

$ #94056
PROPOSAL:

Tests

  1. Open Search and confirm the export menu option reads Current view (not "Export current view").
  2. Select a few expenses and export via Basic export; verify the downloaded file is named Expensify_Basic_export_<id>.csv with no date/time in the name.
  3. Select a few expenses and export via Current view; verify the file is named Expensify_Current_view_<id>.csv.
  4. Select all matching items and export; verify the async/Concierge-delivered file uses the same Expensify_<name>_<id>.csv pattern.
  5. Export via All Data - expense level; verify the file is named Expensify_All_Data_-_Expense_Level_Export_<id>.csv.
  6. Download a receipt/attachment and verify it still includes a timestamp in its filename (regression check that the appendTimestamp default is unchanged).
  7. Verify that no errors appear in the JS console.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline and trigger an export; verify the offline modal appears and no malformed download occurs.

QA Steps

  1. Same as the Tests section above, run on the staging environment.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index f034b867164..16bb024f7f2 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -9666,7 +9666,7 @@ Hier ist ein *Testbeleg*, um dir zu zeigen, wie es funktioniert:`,
         expenseLevelExport: 'Alle Daten – Ausgabenebene',
         exportInProgress: 'Export wird ausgeführt',
         conciergeWillSend: 'Concierge wird dir die Datei in Kürze senden.',
-        currentView: 'Aktuelle Ansicht exportieren',
+        currentView: 'Aktuelle Ansicht',
     },
     exportDownload: {
         preparingTitle: 'Preparing download...',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 2f27bd487c1..36d2362c824 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -9698,7 +9698,7 @@ Voici un *reçu test* pour vous montrer comment ça fonctionne :`,
         expenseLevelExport: 'Toutes les données - niveau dépense',
         exportInProgress: 'Export en cours',
         conciergeWillSend: 'Concierge vous enverra le fichier sous peu.',
-        currentView: 'Exporter la vue actuelle',
+        currentView: 'Vue actuelle',
     },
     exportDownload: {
         preparingTitle: 'Preparing download...',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 70091ab871d..5deadc5c585 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -9654,7 +9654,7 @@ Ecco una *ricevuta di prova* per mostrarti come funziona:`,
         expenseLevelExport: 'Tutti i dati - livello spesa',
         exportInProgress: 'Esportazione in corso',
         conciergeWillSend: 'Concierge ti invierà il file a breve.',
-        currentView: 'Esporta vista corrente',
+        currentView: 'Vista corrente',
     },
     exportDownload: {
         preparingTitle: 'Preparing download...',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 63a0996d063..352d036affb 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -9531,7 +9531,7 @@ ${reportName}`,
         expenseLevelExport: 'すべてのデータ - 経費レベル',
         exportInProgress: 'エクスポート処理中',
         conciergeWillSend: 'Conciergeがまもなくファイルを送信します。',
-        currentView: '現在のビューをエクスポート',
+        currentView: '現在のビュー',
     },
     exportDownload: {
         preparingTitle: 'Preparing download...',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 96a213436b3..0d92bf3c6c4 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -9620,7 +9620,7 @@ Hier is een *proefbon* om je te laten zien hoe het werkt:`,
         expenseLevelExport: 'Alle gegevens - uitgaveniveau',
         exportInProgress: 'Export bezig',
         conciergeWillSend: 'Concierge stuurt je het bestand zo meteen.',
-        currentView: 'Huidige weergave exporteren',
+        currentView: 'Huidige weergave',
     },
     exportDownload: {
         preparingTitle: 'Preparing download...',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 9519f36c061..62e10647cb8 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -9605,7 +9605,7 @@ Oto *paragon testowy*, żeby pokazać Ci, jak to działa:`,
         expenseLevelExport: 'Wszystkie dane – poziom wydatku',
         exportInProgress: 'Trwa eksport',
         conciergeWillSend: 'Concierge wkrótce wyśle Ci plik.',
-        currentView: 'Eksportuj bieżący widok',
+        currentView: 'Bieżący widok',
     },
     exportDownload: {
         preparingTitle: 'Preparing download...',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index c1092488265..84971b93c0b 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -9609,7 +9609,7 @@ Aqui está um *comprovante de teste* para mostrar como funciona:`,
         expenseLevelExport: 'Todos os dados - nível de despesa',
         exportInProgress: 'Exportação em andamento',
         conciergeWillSend: 'O Concierge enviará o arquivo para você em breve.',
-        currentView: 'Exportar visão atual',
+        currentView: 'Visualização atual',
     },
     exportDownload: {
         preparingTitle: 'Preparing download...',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index ff7f6a47ba8..f40e8a148b0 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -9349,7 +9349,7 @@ ${reportName}`,
         expenseLevelExport: '所有数据 - 报销级别',
         exportInProgress: '导出进行中',
         conciergeWillSend: 'Concierge 将很快把文件发送给你。',
-        currentView: '导出当前视图',
+        currentView: '当前视图',
     },
     exportDownload: {
         preparingTitle: 'Preparing download...',

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants