Rename "Export current view" option and standardize export filenames#94083
Draft
rlinoz wants to merge 4 commits into
Draft
Rename "Export current view" option and standardize export filenames#94083rlinoz wants to merge 4 commits into
rlinoz wants to merge 4 commits into
Conversation
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index f034b867164..16bb024f7f2 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -9666,7 +9666,7 @@ Hier ist ein *Testbeleg*, um dir zu zeigen, wie es funktioniert:`,
expenseLevelExport: 'Alle Daten – Ausgabenebene',
exportInProgress: 'Export wird ausgeführt',
conciergeWillSend: 'Concierge wird dir die Datei in Kürze senden.',
- currentView: 'Aktuelle Ansicht exportieren',
+ currentView: 'Aktuelle Ansicht',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 2f27bd487c1..36d2362c824 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -9698,7 +9698,7 @@ Voici un *reçu test* pour vous montrer comment ça fonctionne :`,
expenseLevelExport: 'Toutes les données - niveau dépense',
exportInProgress: 'Export en cours',
conciergeWillSend: 'Concierge vous enverra le fichier sous peu.',
- currentView: 'Exporter la vue actuelle',
+ currentView: 'Vue actuelle',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 70091ab871d..5deadc5c585 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -9654,7 +9654,7 @@ Ecco una *ricevuta di prova* per mostrarti come funziona:`,
expenseLevelExport: 'Tutti i dati - livello spesa',
exportInProgress: 'Esportazione in corso',
conciergeWillSend: 'Concierge ti invierà il file a breve.',
- currentView: 'Esporta vista corrente',
+ currentView: 'Vista corrente',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 63a0996d063..352d036affb 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -9531,7 +9531,7 @@ ${reportName}`,
expenseLevelExport: 'すべてのデータ - 経費レベル',
exportInProgress: 'エクスポート処理中',
conciergeWillSend: 'Conciergeがまもなくファイルを送信します。',
- currentView: '現在のビューをエクスポート',
+ currentView: '現在のビュー',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 96a213436b3..0d92bf3c6c4 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -9620,7 +9620,7 @@ Hier is een *proefbon* om je te laten zien hoe het werkt:`,
expenseLevelExport: 'Alle gegevens - uitgaveniveau',
exportInProgress: 'Export bezig',
conciergeWillSend: 'Concierge stuurt je het bestand zo meteen.',
- currentView: 'Huidige weergave exporteren',
+ currentView: 'Huidige weergave',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 9519f36c061..62e10647cb8 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -9605,7 +9605,7 @@ Oto *paragon testowy*, żeby pokazać Ci, jak to działa:`,
expenseLevelExport: 'Wszystkie dane – poziom wydatku',
exportInProgress: 'Trwa eksport',
conciergeWillSend: 'Concierge wkrótce wyśle Ci plik.',
- currentView: 'Eksportuj bieżący widok',
+ currentView: 'Bieżący widok',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index c1092488265..84971b93c0b 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -9609,7 +9609,7 @@ Aqui está um *comprovante de teste* para mostrar como funciona:`,
expenseLevelExport: 'Todos os dados - nível de despesa',
exportInProgress: 'Exportação em andamento',
conciergeWillSend: 'O Concierge enviará o arquivo para você em breve.',
- currentView: 'Exportar visão atual',
+ currentView: 'Visualização atual',
},
exportDownload: {
preparingTitle: 'Preparing download...',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index ff7f6a47ba8..f40e8a148b0 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -9349,7 +9349,7 @@ ${reportName}`,
expenseLevelExport: '所有数据 - 报销级别',
exportInProgress: '导出进行中',
conciergeWillSend: 'Concierge 将很快把文件发送给你。',
- currentView: '导出当前视图',
+ currentView: '当前视图',
},
exportDownload: {
preparingTitle: 'Preparing download...',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Two changes from the linked issue:
Expensify_<exportName>_<uniqueID>.csvname, where<exportName>is the UI label (e.g. "Current view", "Basic export"). The date/time suffix is dropped (the OS already records download time); a unique id prevents collisions.To do this:
getExportFileName(exportName, uniqueID, extension)builds the standardized name.fileDownloadgains an opt-outappendTimestampflag (defaulttrue, so all other downloads — attachments, receipts, statements, QR codes — keep their timestamp); the export flows passfalse.exportNameparam throughexportSearchItemsToCSV,queueExportSearchItemsToCSV, andqueueExportSearchWithTemplate, plus every caller in the Search and report-header export menus.The async/Concierge and template exports are named on the backend; see the companion PR: https://github.com/Expensify/Web-Expensify/pull/53872
Fixed Issues
$ #94056
PROPOSAL:
Tests
Expensify_Basic_export_<id>.csvwith no date/time in the name.Expensify_Current_view_<id>.csv.Expensify_<name>_<id>.csvpattern.Expensify_All_Data_-_Expense_Level_Export_<id>.csv.appendTimestampdefault is unchanged).Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari