Skip to content

Conversation

@Houdini
Copy link
Contributor

@Houdini Houdini commented Dec 4, 2025

  1. floc header is obsolete
  2. Condition is wrong anyway, it should be == instead of !==

@Houdini Houdini force-pushed the remove-floc-header branch from 12d3c58 to fa551d1 Compare December 4, 2025 01:57
@Houdini
Copy link
Contributor Author

Houdini commented Dec 8, 2025

@bryannielsen Hello, could you please check that PR. Is these tests are really necessary?
They probably failed because of my old branch, can we ignore that?

@bryannielsen
Copy link
Contributor

@Houdini it looks like the new Topics API that replaced FLoC still respects this header to "opt out of user tracking for interest-based advertising". The logic looks correct based on the docs but I see that a similar request was made to remove the header from the core which is where this particular code came from so I think we can move this forward.

It looks like the Laravel 9 tests are failing because of an issue composer audit found. I think we can add the ignore rule for this because any security issues with Laravel 9 are a concern for the user but not our tests.

@bryannielsen bryannielsen merged commit 21a9950 into ExpressionEngine:2.x Dec 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants