Fix project creation failing when workspace path has spaces#514
Open
bhavyabhardwaj001 wants to merge 1 commit into
Open
Fix project creation failing when workspace path has spaces#514bhavyabhardwaj001 wants to merge 1 commit into
bhavyabhardwaj001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #478
Purpose
Project creation fails on Windows when the workspace path contains spaces.
The current validation incorrectly checks the full project path instead of just the project name, causing valid project names to be rejected.
Approach
os.path.basename()Changes Made
Validation.pyprojDirwith check on extracted project name (projName)Impact
Verification