Skip to content

fix(review): show LGTM when review finds no issues #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhay-factory wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(review): show LGTM when review finds no issues #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/core/skills/review/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,4 +248,6 @@ Before approving a candidate:

When invoked locally (TUI/CLI), analyze the changes and provide a structured summary of findings. List each finding with its priority, file, line, and description.

If the review produces **no findings**, respond with a short **LGTM** message (e.g., "LGTM — no issues found."). Do not pad it with caveats or disclaimers.
Copy link
Copy Markdown
Contributor

@factory-nizar factory-nizar Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a good change, but do we want to update the original comment about the droid working, or post a new comment?


Do **not** post inline comments to the PR or submit a GitHub review unless the user explicitly asks for it.