-
Notifications
You must be signed in to change notification settings - Fork 27
Bump @vitejs/plugin-react-swc from 3.11.0 to 4.2.2 in /app #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Bump @vitejs/plugin-react-swc from 3.11.0 to 4.2.2 in /app #320
Conversation
Completed Working on "Code Review"✅ Review submitted: REQUEST_CHANGES. Total comments: 1 across 1 files. |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
Code review completed and review will be submitted shortly. Thank you for your patience! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
- 1 comment (MAJOR) covering the Node runtime compatibility risk introduced by this dependency bump.
Details
Upgrading @vitejs/plugin-react-swc to 4.2.2 now requires Node ^20.19.0 || >=22.12.0, but this repo still runs builds/tests on Node 18 (per the lockfile engines entry and the current CI workflow). npm ci will begin failing in CI and for every developer still on Node 18 as soon as this lands.
Next steps
- Align the project tooling with the new engine requirement (update CI to install Node ≥20.19, document the new minimum version, etc.) or pin the plugin to the latest 3.x release until the Node upgrade work is complete.
| "@types/react": "^18.3.23", | ||
| "@types/react-dom": "^18.3.7", | ||
| "@vitejs/plugin-react-swc": "^3.11.0", | ||
| "@vitejs/plugin-react-swc": "^4.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MAJOR]: Upgrading @vitejs/plugin-react-swc to 4.2.2 now inherits the plugin’s new engines requirement of Node ^20.19 || >=22.12 (see the engines block added for this dependency in app/package-lock.json). Our repo still targets Node 18 in docs/CI, so npm ci/npm run build will fail with EBADENGINE before tests execute. Please either keep the plugin on 3.11.0 or, preferably, bump the project to Node ≥22 (pin the CI runner via actions/setup-node, add matching .nvmrc/engines entries, and document the new requirement).
| "@swc/core": "^1.13.5" | ||
| }, | ||
| "engines": { | ||
| "node": "^20.19.0 || >=22.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitejs/[email protected] now advertises engines.node: ^20.19.0 || >=22.12.0, which is higher than what this repo currently targets (the root packages[""].engines.node entry in this lockfile is still >=18, and .github/workflows/tests.yml never installs a newer runtime—it simply runs npm ci on the runner’s default Node 18). Installing this dependency will start erroring in CI and for every developer who hasn’t moved to Node ≥20.19 yet. Please either (a) bump the project toolchain (add setup-node 20+ in workflows, update any .nvmrc/docs) before merging, or (b) pin @vitejs/plugin-react-swc to the latest 3.x release until the Node upgrade work is done.
60be862 to
2c97a46
Compare
770c9eb to
9373d4e
Compare
Bumps [@vitejs/plugin-react-swc](https://github.com/vitejs/vite-plugin-react/tree/HEAD/packages/plugin-react-swc) from 3.11.0 to 4.2.2. - [Release notes](https://github.com/vitejs/vite-plugin-react/releases) - [Changelog](https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react-swc/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite-plugin-react/commits/[email protected]/packages/plugin-react-swc) --- updated-dependencies: - dependency-name: "@vitejs/plugin-react-swc" dependency-version: 4.2.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
9373d4e to
0379254
Compare
Bumps @vitejs/plugin-react-swc from 3.11.0 to 4.2.2.
Release notes
Sourced from
@vitejs/plugin-react-swc's releases.... (truncated)
Changelog
Sourced from
@vitejs/plugin-react-swc's changelog.Commits
5e600a3release: [email protected]bcc7db0chore: add changelog for #976 and #97817fdcc8fix(react-swc,react-oxc): use rolldownOptions instead of deprecated rollupOpt...fc76c72chore(deps): update dependency@types/nodeto v24 (#970)41cb823fix(deps): update all non-major dependencies (#968)51160f3release: [email protected]0f5c8b4chore(react-swc): add changelog (#963)897a3befix(react-swc): fix@vitejs/plugin-react-swc/preambleon build (#962)9cabe27fix(deps): update all non-major dependencies (#960)b5f471fchore(deps): update swc monorepo (#954)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for
@vitejs/plugin-react-swcsince your current version.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)