Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js-sdk-framework-tests/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@angular/platform-server": "21.2.3",
"@angular/router": "21.2.3",
"@angular/ssr": "21.2.2",
"express": "5.1.0",
"express": "5.2.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This dependency is pinned to an exact version, while other dependencies in this file use version ranges (e.g., rxjs on line 35 uses ~). This inconsistency in dependency versioning can make maintenance and understanding the dependency strategy more difficult. For better maintainability, I recommend standardizing on a single approach for all dependencies, whether it's pinning for reproducibility or using ranges for flexibility. A separate task could be created to address this across the file.

"rxjs": "~7.8.0",
"tslib": "2.3.0",
"zone.js": "~0.15.0"
Expand All @@ -41,7 +41,7 @@
"@angular/cli": "21.2.2",
"@angular/compiler-cli": "21.2.3",
"@playwright/test": "1.40.1",
"@types/express": "5.0.1",
"@types/express": "5.0.6",
"@types/jasmine": "~5.1.0",
"@types/node": "20.17.19",
"jasmine-core": "~5.8.0",
Expand Down
49 changes: 8 additions & 41 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2819,14 +2819,14 @@
"@types/range-parser" "*"
"@types/send" "*"

"@types/express@5.0.1":
version "5.0.1"
resolved "https://registry.yarnpkg.com/@types/express/-/express-5.0.1.tgz#138d741c6e5db8cc273bec5285cd6e9d0779fc9f"
integrity sha512-UZUw8vjpWFXuDnjFTh7/5c2TWDlQqeXHi6hcN7F2XSVT5P+WmUnnbFS3KA6Jnc6IsEqI2qCVu2bK0R0J4A8ZQQ==
"@types/express@5.0.6":
version "5.0.6"
resolved "https://registry.yarnpkg.com/@types/express/-/express-5.0.6.tgz#2d724b2c990dcb8c8444063f3580a903f6d500cc"
integrity sha512-sKYVuV7Sv9fbPIt/442koC7+IIwK5olP1KWeD88e/idgoJqDm3JV/YUiPwkoKK92ylff2MGxSz1CSjsXelx0YA==
dependencies:
"@types/body-parser" "*"
"@types/express-serve-static-core" "^5.0.0"
"@types/serve-static" "*"
"@types/serve-static" "^2"

"@types/http-errors@*":
version "2.0.5"
Expand Down Expand Up @@ -2903,7 +2903,7 @@
dependencies:
"@types/node" "*"

"@types/serve-static@*":
"@types/serve-static@^2":
version "2.2.0"
resolved "https://registry.yarnpkg.com/@types/serve-static/-/serve-static-2.2.0.tgz#d4a447503ead0d1671132d1ab6bd58b805d8de6a"
integrity sha512-8mam4H1NHLtu7nmtalF7eyBH14QyOASmcxHhSfEoRyr0nP/YdoesEtU+uSRvMe96TW/HPTtkoKqQLl53N7UXMQ==
Expand Down Expand Up @@ -3573,7 +3573,7 @@ body-parser@^1.19.0:
type-is "~1.6.18"
unpipe "~1.0.0"

body-parser@^2.2.0, body-parser@^2.2.1:
body-parser@^2.2.1:
version "2.2.2"
resolved "https://registry.yarnpkg.com/body-parser/-/body-parser-2.2.2.tgz#1a32cdb966beaf68de50a9dfbe5b58f83cb8890c"
integrity sha512-oP5VkATKlNwcgvxi0vM0p/D3n2C3EReYVX+DNYs5TjZFn/oQt2j+4sVJtSMr18pdRr8wjTcBl6LoV+FUwzPmNA==
Expand Down Expand Up @@ -5002,40 +5002,7 @@ express-rate-limit@^8.2.1:
dependencies:
ip-address "10.0.1"

express@5.1.0:
version "5.1.0"
resolved "https://registry.yarnpkg.com/express/-/express-5.1.0.tgz#d31beaf715a0016f0d53f47d3b4d7acf28c75cc9"
integrity sha512-DT9ck5YIRU+8GYzzU5kT3eHGA5iL+1Zd0EutOmTE9Dtk+Tvuzd23VBU+ec7HPNSTxXYO55gPV/hq4pSBJDjFpA==
dependencies:
accepts "^2.0.0"
body-parser "^2.2.0"
content-disposition "^1.0.0"
content-type "^1.0.5"
cookie "^0.7.1"
cookie-signature "^1.2.1"
debug "^4.4.0"
encodeurl "^2.0.0"
escape-html "^1.0.3"
etag "^1.8.1"
finalhandler "^2.1.0"
fresh "^2.0.0"
http-errors "^2.0.0"
merge-descriptors "^2.0.0"
mime-types "^3.0.0"
on-finished "^2.4.1"
once "^1.4.0"
parseurl "^1.3.3"
proxy-addr "^2.0.7"
qs "^6.14.0"
range-parser "^1.2.1"
router "^2.2.0"
send "^1.1.0"
serve-static "^2.2.0"
statuses "^2.0.1"
type-is "^2.0.1"
vary "^1.1.2"

express@^5.2.1:
express@5.2.1, express@^5.2.1:
version "5.2.1"
resolved "https://registry.yarnpkg.com/express/-/express-5.2.1.tgz#8f21d15b6d327f92b4794ecf8cb08a72f956ac04"
integrity sha512-hIS4idWWai69NezIdRt2xFVofaF4j+6INOpJlVOLDO8zXGpUVEVzIYk12UUi2JzjEzWL3IOAxcTubgz9Po0yXw==
Expand Down
Loading