fix: clean-up-ci-cafe-port-3000-on-error#6430
Merged
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 10. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Docker builds report
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6430 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 1292 1292
Lines 46509 46509
=======================================
Hits 45611 45611
Misses 898 898 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
talissoncosta
approved these changes
Dec 18, 2025
gagantrivedi
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!This PR fixes an issue where E2E test retries would hang because port 3000 was still busy with a previous failed attempt.
TestCafe failed during initialization (one concurrent browser failed). There was no error handler and the CI retry wouldn't clean up the port.
The error was in the child process, the parent had no error handler, so it just exited without a proper error code which CI considered a success
Changes
e2e/index.cafe.js).github/workflows/.reusable-docker-e2e-tests.yml)How did you test this code?
With failing testcafe config: