Skip to content

Conversation

@talissoncosta
Copy link
Contributor

@talissoncosta talissoncosta commented Dec 19, 2025

Summary

Add Jest unit testing infrastructure to the frontend codebase to enable fast, isolated unit tests alongside the existing TestCafe E2E tests.

Closes #6442

Changes

Jest Configuration

  • Add Jest with ts-jest preset for TypeScript support
  • Configure module path aliases (common/, components/, project/)
  • Set up coverage collection for common/ and web/ directories

CI/CD Integration

  • Add new GitHub Actions workflow (frontend-pull-request.yml)
  • Runs unit tests automatically on PRs that modify frontend code

Initial Test Coverage

  • Add comprehensive unit tests for featureFilterParams utility
  • Tests cover buildUrlParams, buildApiFilterParams, getFiltersFromParams, hasActiveFilters

Dependencies Added

  • jest, ts-jest, @types/jest

How did you test this code?

cd frontend
npm run test:unit

All 27 tests pass.

Checklist

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below
  • I have filled in the "How did you test this code" section below
  • I have used a Conventional Commit title for this Pull Request

- Add Jest with ts-jest for TypeScript support
- Add jest.config.js with path aliases matching tsconfig
- Add npm scripts: test:unit, test:unit:watch, test:unit:coverage
- Migrate format.js to format.ts for better Jest compatibility
- Add unit tests for featureFilterParams utility

Tests cover:
- buildUrlParams: is_archived always explicitly set (never undefined)
- buildApiFilterParams: is_archived always included in API params
- getFiltersFromParams: URL param parsing
- hasActiveFilters: filter state detection

This prevents regression of the archived features bug where is_archived
was undefined instead of explicitly 'false'.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Dec 25, 2025 6:43pm
flagsmith-frontend-staging Ready Ready Preview, Comment Dec 25, 2025 6:43pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Preview Dec 25, 2025 6:43pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 19, 2025
Runs Jest unit tests on PRs that modify frontend/ files.
Runs on all PRs including drafts (tests are fast and cheap).

Lint and typecheck can be added later once those are cleaned up.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@talissoncosta talissoncosta force-pushed the feat/add-jest-unit-tests branch from ef6d2cb to 0635372 Compare December 19, 2025 00:57
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2@0d87098). Learn more about missing BASE report.

Additional details and impacted files
@@                                               Coverage Diff                                                @@
##             revert-6428-revert-6361-refactor/migrate-critical-components-featurespagejs-2    #6432   +/-   ##
================================================================================================================
  Coverage                                                                                 ?   98.06%           
================================================================================================================
  Files                                                                                    ?     1292           
  Lines                                                                                    ?    46509           
  Branches                                                                                 ?        0           
================================================================================================================
  Hits                                                                                     ?    45611           
  Misses                                                                                   ?      898           
  Partials                                                                                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talissoncosta talissoncosta linked an issue Dec 25, 2025 that may be closed by this pull request
@talissoncosta talissoncosta changed the title POC: unit tests feat(frontend): add Jest unit testing infrastructure Dec 25, 2025
@talissoncosta talissoncosta marked this pull request as ready for review December 25, 2025 17:59
@talissoncosta talissoncosta requested review from a team as code owners December 25, 2025 17:59
@talissoncosta talissoncosta requested review from Zaimwa9 and removed request for a team December 25, 2025 17:59
@github-actions github-actions bot added the feature New feature or request label Dec 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6432 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6432 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6432 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6432 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6432 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-6432 Finished ✅ Results

- Add 45 unit tests for Format utility pure functions
- Remove unnecessary .toString() in countdown: parseInt(x.toString()) → Math.floor(x)
- Remove unnecessary .toString() in shortenNumber: +parseFloat(x.toString()).toFixed(1) → +x.toFixed(1)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add explicit moment import to fix TypeScript UMD global error
- Simplify money() to consistently return defaultValue for null/undefined/0
- Update tests to reflect new behavior

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Copy link
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just adding a prop and to the deploy to production pipeline and should be good to go. Thanks for the initiative!

@@ -0,0 +1,33 @@
name: Frontend Pull Requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add the tests in the deploy to production workflow

@@ -0,0 +1,30 @@
/** @type {import('jest').Config} */
module.exports = {
collectCoverageFrom: [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember a clearMocks prop maybe that could be worth adding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(frontend): Add Jest unit testing infrastructure

3 participants