Skip to content

Conversation

@matthewelwell
Copy link
Contributor

Changes

Optimises the handle_api_usage_notifications task in 2 ways:

  1. Only run the logic for organisations with a subscription cache record
  2. Only request data from influx for organisations that have exceeded the minimum notification threshold in the last 30 days

How did you test this code?

Updated existing tests

@matthewelwell matthewelwell requested a review from a team as a code owner January 2, 2026 23:34
@matthewelwell matthewelwell requested review from emyller and removed request for a team January 2, 2026 23:34
@vercel
Copy link

vercel bot commented Jan 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Review Updated (UTC)
docs Ignored Ignored Preview Jan 2, 2026 11:53pm
flagsmith-frontend-preview Ignored Ignored Preview Jan 2, 2026 11:53pm
flagsmith-frontend-staging Ignored Ignored Preview Jan 2, 2026 11:53pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-6458 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-6458 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-6458 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-6458 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-6458 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6458 Finished ✅ Results

emyller
emyller previously approved these changes Jan 2, 2026
@github-actions github-actions bot added fix and removed fix labels Jan 2, 2026
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.07%. Comparing base (38ac162) to head (9e6ec99).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6458   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files        1294     1294           
  Lines       46535    46537    +2     
=======================================
+ Hits        45637    45639    +2     
  Misses        898      898           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added fix and removed fix labels Jan 2, 2026
@matthewelwell matthewelwell requested a review from emyller January 2, 2026 23:55
Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewelwell matthewelwell merged commit 26ac021 into main Jan 4, 2026
29 checks passed
@matthewelwell matthewelwell deleted the fix/api-usage-notification-optimisations branch January 4, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants