Skip to content

ci: Pin third-party GitHub Actions to commit SHAs#7727

Open
matthewelwell wants to merge 1 commit into
mainfrom
ci/pin-gha
Open

ci: Pin third-party GitHub Actions to commit SHAs#7727
matthewelwell wants to merge 1 commit into
mainfrom
ci/pin-gha

Conversation

@matthewelwell

@matthewelwell matthewelwell commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Hardens our workflows against supply-chain attacks targeting GitHub Actions repositories (e.g. the recent tj-actions/changed-files compromise) by pinning every third-party uses: reference to a full 40-character commit SHA with a trailing # vX.Y.Z comment.

  • 109 third-party action references across 30 files now use owner/repo@<full-sha> # vX.Y.Z.
  • Two refs that floated on @main are pinned to their latest stable release SHA, which is a minor behaviour change worth flagging:
    • fjogeleit/yaml-update-action@mainv0.17.0
    • actions-cool/check-user-permission@mainv2.0.1
  • Local ./... references and Flagsmith/* actions are intentionally left on version tags.
  • renovate.json extends helpers:pinGitHubActionDigests so any newly added action is auto-pinned to a digest in its first Renovate PR. Flagsmith/** is excluded via a package rule. The existing security:only-security-updates preset is preserved, so SHAs only refresh when a CVE is published.

How did you test this code?

  • renovate-config-validator passed locally via the pre-push hook.
  • Workflow behaviour is exercised by the standard PR triggers on this branch (api / frontend / mcp / docs / platform pull-request workflows). Please re-check that all CI jobs pass on this PR before merging.

🤖 Generated with Claude Code

Pin every third-party `uses:` ref across `.github/workflows/` and
`.github/actions/` to its full 40-char commit SHA with a trailing
`# vX.Y.Z` comment, hardening the workflows against supply-chain
attacks targeting action repositories.

Two refs that floated on `@main` are now pinned to their latest
stable releases:
- `fjogeleit/yaml-update-action` -> v0.17.0
- `actions-cool/check-user-permission` -> v2.0.1

Local `./...` refs and `Flagsmith/*` actions are intentionally
left on tags.

`renovate.json` extends `helpers:pinGitHubActionDigests` so newly
added actions are auto-pinned, with `Flagsmith/**` excluded.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@matthewelwell matthewelwell requested a review from a team as a code owner June 8, 2026 10:25
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team June 8, 2026 10:25
@vercel

vercel Bot commented Jun 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Jun 8, 2026 10:25am
flagsmith-frontend-preview Ignored Ignored Jun 8, 2026 10:25am
flagsmith-frontend-staging Ignored Ignored Jun 8, 2026 10:25am

Request Review

@github-actions github-actions Bot added the ci-cd Build, test and deployment related label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-7727 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-7727 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7727 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-7727 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-7727 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7727 Finished ✅ Results

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.1 seconds
commit  b972a02
info  🔄 Run: #17329 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  44.2 seconds
commit  b972a02
info  🔄 Run: #17329 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  32.1 seconds
commit  b972a02
info  🔄 Run: #17329 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  1 minute, 11 seconds
commit  b972a02
info  🔄 Run: #17329 (attempt 1)

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.54%. Comparing base (d0ac9b5) to head (b972a02).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7727      +/-   ##
==========================================
+ Coverage   98.38%   98.54%   +0.16%     
==========================================
  Files        1446     1452       +6     
  Lines       55321    55757     +436     
==========================================
+ Hits        54427    54947     +520     
+ Misses        894      810      -84     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd Build, test and deployment related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants