Skip to content

ci(frontend): lint changed files on pull requests#7748

Open
talissoncosta wants to merge 1 commit into
mainfrom
ci/frontend-lint-changed-files
Open

ci(frontend): lint changed files on pull requests#7748
talissoncosta wants to merge 1 commit into
mainfrom
ci/frontend-lint-changed-files

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Adds a lint job to the frontend PR workflow that runs eslint on only the files changed in the PR, hard-failing on errors.

Diff-scoped because the frontend has a large pre-existing backlog (~1,650 tsc errors + eslint violations), so a whole-repo gate isn't viable yet — this stops new lint/format debt without blocking on legacy. eslint extends plugin:prettier/recommended, so formatting is covered too. Fails on error-level rules only (conservative v1).

How did you test this code?

Pushed a temp nested-ternary into a changed .ts file on this branch: the job hard-failed with a file/line annotation; removing it made the job skip and pass. Also ran the diff-scoped command locally against #7733 (caught 7 real errors).

@talissoncosta talissoncosta requested a review from a team as a code owner June 10, 2026 19:30
@talissoncosta talissoncosta requested review from Zaimwa9 and removed request for a team June 10, 2026 19:30
@vercel

vercel Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs Ignored Ignored Preview Jun 10, 2026 7:38pm
flagsmith-frontend-preview Ignored Ignored Preview Jun 10, 2026 7:38pm
flagsmith-frontend-staging Ignored Ignored Preview Jun 10, 2026 7:38pm

Request Review

@talissoncosta talissoncosta requested a review from a team as a code owner June 10, 2026 19:33
@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7748 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-7748 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-7748 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-7748 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-7748 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7748 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-7748 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-7748 Finished ✅ Results ✅

@github-actions github-actions Bot added the ci-cd Build, test and deployment related label Jun 10, 2026
@talissoncosta talissoncosta force-pushed the ci/frontend-lint-changed-files branch from 0dd58f1 to 66cf73f Compare June 10, 2026 19:34
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.54%. Comparing base (5ef4042) to head (a51a1ec).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7748      +/-   ##
==========================================
+ Coverage   98.48%   98.54%   +0.06%     
==========================================
  Files        1453     1453              
  Lines       55809    55836      +27     
==========================================
+ Hits        54964    55026      +62     
+ Misses        845      810      -35

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@talissoncosta @claude
ci(frontend): lint changed files on pull requests
a51a1ec 
Adds a lint job to the frontend PR workflow that runs eslint on only the
files changed in the PR. The frontend has a large pre-existing eslint/tsc
backlog, so a whole-repo gate isn't viable — diff-scoping stops new
violations without blocking on legacy debt. eslint extends
plugin:prettier/recommended, so this also catches formatting issues.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@talissoncosta talissoncosta force-pushed the ci/frontend-lint-changed-files branch from 66cf73f to a51a1ec Compare June 10, 2026 19:38
@github-actions github-actions Bot added ci-cd Build, test and deployment related and removed ci-cd Build, test and deployment related labels Jun 10, 2026
@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  46.1 seconds
commit  66cf73f
info  🔄 Run: #17404 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  32.3 seconds
commit  66cf73f
info  🔄 Run: #17404 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute
commit  66cf73f
info  🔄 Run: #17404 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  36.9 seconds
commit  66cf73f
info  🔄 Run: #17404 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40.6 seconds
commit  66cf73f
info  🔄 Run: #17406 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.5 seconds
commit  66cf73f
info  🔄 Run: #17406 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  40.2 seconds
commit  0dd58f1
info  🔄 Run: #17405 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  39.6 seconds
commit  66cf73f
info  🔄 Run: #17406 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  43.8 seconds
commit  a51a1ec
info  🔄 Run: #17407 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  37.4 seconds
commit  66cf73f
info  🔄 Run: #17406 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  59.3 seconds
commit  a51a1ec
info  🔄 Run: #17407 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.4 seconds
commit  0dd58f1
info  🔄 Run: #17405 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  1 minute, 8 seconds
commit  a51a1ec
info  🔄 Run: #17407 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  42.2 seconds
commit  a51a1ec
info  🔄 Run: #17407 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.4 seconds
commit  0dd58f1
info  🔄 Run: #17405 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  1 minute
commit  0dd58f1
info  🔄 Run: #17405 (attempt 1)

@github-actions

github-actions Bot commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Visual Regression

19 screenshots compared. See report for details.
View full report

@talissoncosta talissoncosta mentioned this pull request Jun 10, 2026
Closed
@talissoncosta talissoncosta self-assigned this Jun 11, 2026
Zaimwa9
Zaimwa9 approved these changes Jun 11, 2026
View reviewed changes

@Zaimwa9 Zaimwa9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zaimwa9 Zaimwa9 Zaimwa9 approved these changes

Assignees

@talissoncosta talissoncosta

@Zaimwa9 Zaimwa9

Labels

ci-cd Build, test and deployment related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@talissoncosta @Zaimwa9