Skip to content

fix(frontend): Fix inconsistent tooltip appearances and behaviours#7750

Open
afsuyadi wants to merge 3 commits into
Flagsmith:mainfrom
afsuyadi:fix-inconsistent-tooltip
Open

fix(frontend): Fix inconsistent tooltip appearances and behaviours#7750
afsuyadi wants to merge 3 commits into
Flagsmith:mainfrom
afsuyadi:fix-inconsistent-tooltip

Conversation

@afsuyadi

@afsuyadi afsuyadi commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • [✓] I have read the Contributing Guide.
  • [✓] I have added information to docs/ if required so people know about the feature.
  • [✓] I have filled in the "Changes" section below.
  • [✓] I have filled in the "How did you test this code" section below.

Changes

Contributes to #7703

Based on the acceptance criteria, these changes were made:

  1. Unify the font-weight for Tooltip component
  2. Remove arrow from Tooltip component
  3. Remove redundant Tooltip from Identity Overrides tab (already sufficient with the InfoMessage component)

How did you test this code?

Before any changes:
Screencast+from+11-06-26+07_09_01.webm

Screencast.from.11-06-26.07.41.34.webm

After Changes:
Screencast from 11-06-26 08:10:08.webm

Additional note: I have checked other redundant items - where a Tooltip & InfoMessage with similar description exists - but none is found, only in the Identity Overrides tab. CMIIW

@afsuyadi afsuyadi requested a review from a team as a code owner June 11, 2026 01:11
@afsuyadi afsuyadi requested review from talissoncosta and removed request for a team June 11, 2026 01:11
@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

@afsuyadi is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the front-end Issue related to the React Front End Dashboard label Jun 11, 2026
@SahilJat

Copy link
Copy Markdown
Contributor

Hi @afsuyadi pr look pretty good , here are some changes or suggestions that can be looked at:

  1. Dead CSS: The .react-tooltip-arrow rules in _tooltips.scss (and the $arrow variable) are now unreachable since noArrow is applied globally. You can remove them to keep the stylesheet clean.

  2. line-height: The issue's acceptance criteria explicitly mentions setting a reasonable line-height. Could you confirm this has been visually checked and is acceptable, or add an explicit line-height value to the tooltip base styles?

  3. Nit: Consider moving fontWeight: 'normal' from the inline style to _tooltips.scss alongside the other base typographic rules — keeps things consistent and easier to maintain.
    Thanks.

@SahilJat SahilJat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks preety good , some changes can be considered (mentioned in the comment)

@afsuyadi

Copy link
Copy Markdown
Contributor Author

Thanks for the review @SahilJat , but I'll wait for the official maintainers' response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants