test: Migrate to pytest-lazy-fixtures#7761
Open
matthewelwell wants to merge 1 commit into
Open
Conversation
pytest-lazy-fixture 0.6.3 has been unmaintained since 2020 and is
incompatible with pytest 8+ (it relies on `CallSpec2.funcargs`, removed
in pytest 9). Replace it with the maintained pytest-lazy-fixtures fork,
rewriting all `lazy_fixture("name")` call sites to `lf("name")`. The new
package ships type hints, so the `# type: ignore[import-untyped]`
comments on its imports are no longer needed.
This unblocks lifting the pytest version cap.
Closes #7759
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Contributor
Docker builds report
|
4 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7761 +/- ##
==========================================
- Coverage 98.55% 98.40% -0.16%
==========================================
Files 1454 1454
Lines 56000 55995 -5
==========================================
- Hits 55193 55104 -89
- Misses 807 891 +84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
|
Contributor
Visual Regression19 screenshots compared. See report for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #7759
pytest-lazy-fixture0.6.3 has been unmaintained since 2020 and is incompatible with pytest 8+ — it relies on pytest's internalCallSpec2.funcargs, removed in pytest 9, causing every test module that imports it to error at collection. This currently forces us to keep pytest capped below 8 (see #7756).This PR migrates to the maintained
pytest-lazy-fixturesfork:pytest-lazy-fixture>=0.6.3,<0.7.0withpytest-lazy-fixtures>=1.4.0,<2.0.0in thedevextra, and dropped thepytest-lazy-fixture==0.6.3entry from[tool.uv].override-dependencies.lazy_fixture("name")call sites across 35 test files to the newlf("name")API. The change is purely mechanical — no test logic touched.# type: ignore[import-untyped]comments on the imports, sincepytest-lazy-fixturesships type hints (py.typed).The remaining acceptance criteria on #7759 (lifting the
pytest<8cap and removing the TODO markers) live on the #7756 branch and will be handled there once this is merged.How did you test this code?
make typecheck—Success: no issues found in 1697 source files.tests/integrationmodules).