fix(frontend): gate app boot on ConfigStore.hasLoaded to avoid loader deadlock#7785
Merged
Conversation
ConfigStore.model is never populated (getAllFlags() returns nothing at the point config-store assigns it), so the provider always started in the loading state even when the store had already finished loading. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The SDK's onChange can fire between the constructor reading the store and componentDidMount subscribing to it. In E2E mode realtime, events and analytics are disabled, so the missed event left the app on the boot loader indefinitely. Re-read the store after subscribing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This was referenced Jun 15, 2026
Contributor
Docker builds report
|
github-actions
Bot
added
the
front-end
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7785 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 1460 1460
Lines 56459 56459
=======================================
Hits 55652 55652
Misses 807 807 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
|
Contributor
Visual Regression19 screenshots compared. See report for details. |
talissoncosta
force-pushed
the
fix/e2e-prod-flakiness
branch
from
2e8b274 to
a6bb897
Compare
talissoncosta
changed the title
Zaimwa9
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the intermittent E2E failure blocking the production deploy gate: the app booting into a permanent loader.
ConfigProviderderivedisLoadingfromConfigStore.model, which is never populated, so it always started loading and relied on the store's one-shotchangeevent to release it. If the Flagsmith SDK'sonChangefired beforecomponentDidMountsubscribed, that event was lost — and with realtime/events disabled in E2E, nothing recovered it, so the app stuck on the loader.ConfigStore.hasLoadedinstead ofmodel.How did you test this code?
Forced the race (delayed the subscription so
onChangealways lands in the gap) and loaded/loginon 15 fresh contexts: main 15/15 stuck on the loader, this fix 0/15.