Repository navigation
feat(tokens): add the content tag palette - #8686
talissoncosta wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change adds content-colour tokens and updates token generation to emit TypeScript colour definitions, SCSS variables and tag utility classes. Contrast utilities and tests check the swatch colours against the shared dark ink colour. The palette story displays token-derived swatches and their contrast ratios. Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The palette outputs and contrast coverage are consistent, with no current merge-blocking risk identified.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
front-end
Docker builds report
|
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #21324 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
🗂️ Previous results✅ private-cloud · depot-ubuntu-latest-16 — run #21324 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #21324 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #21324 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #21309 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ private-cloud · depot-ubuntu-latest-16 — run #21309 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #21309 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #21309 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #21263 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)
Details
✅ private-cloud · depot-ubuntu-latest-16 — run #21263 (attempt 1)Playwright Test Results (private-cloud - depot-ubuntu-latest-16)
Details
✅ oss · depot-ubuntu-latest-arm-16 — run #21263 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-arm-16)
Details
✅ oss · depot-ubuntu-latest-16 — run #21263 (attempt 1)Playwright Test Results (oss - depot-ubuntu-latest-16)
Details
|
Visual Regression20 screenshots compared. See report for details. |
|
@themis-blindfold review |
![themis-blindfold[bot]](https://avatars.githubusercontent.com/in/4278417?s=60&v=4){kind=small}
⚖️ Themis review: 🧹 Ship it, nits insideThe palette, generated TypeScript, CSS utilities, and Storybook swatches are aligned, and all recorded checks passed. One test filter can skip a future fill that exactly matches the shared ink, allowing the accessibility regression it is intended to prevent.
🧹 Nits
📝 Walkthrough
🧪 How to verify
Product take: A solid accessibility foundation for the follow-up tag migration. It has no user-facing effect until that consumer lands, but it removes the contrast risk from the eventual palette. 🧭 Assumptions & unverified claimsNo unverified assumptions or claims. The swatches are doing their accessibility stretches before the tags arrive · reviewed at 55fec31 |
55fec31 to
801c8a8
Compare
github-actions
Bot
added
feature
801c8a8 to
2f6fb21
Compare
github-actions
Bot
added
feature
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Organization UI
- Review profile: ASSERTIVE
- Plan: Advanced
- Run ID:
2f401894-57db-475c-aea7-d93ea9638ce7
📒 Files selected for processing (3)
frontend/common/theme/__tests__/tagSwatches.test.tsfrontend/common/theme/tokens.tsfrontend/scripts/generate-tokens.mjs
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
2f6fb21 to
a09bf6d
Compare
github-actions
Bot
added
feature
The palette a tag's colour is chosen from, emitted as a typed list so a caller looks a colour up rather than computing one, with a contrast helper and a test that reports every failing tint at once. Nothing consumes it yet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
a09bf6d to
127a7ed
Compare
github-actions
Bot
added
feature
This branch was successfully deployed
2 participants
docs/if required so people know about the feature.Changes
Contributes to #8465
1/4, splitting #8613 into reviewable pieces.
The palette a tag's colour comes from, emitted by the token generator as a typed list so callers look a colour up instead of computing one from a stored hex. Adds a contrast helper, and marks the generated token files in
.gitattributesso they collapse in diffs.Nothing consumes it yet;
Tagpicks it up in #8689.How did you test this code?
npm run test:unitcovers it:common/theme/__tests__/tagSwatches.test.tsasserts every tint clears contrast in both themes, reporting all failures at once rather than stopping at the first.Typecheck at main's baseline, 916 errors both sides.
Visual check:
npm run storybook