Fix Device based MCP error log in app log#6587
Conversation
Nice - the new logic to prevent invalid instances being added to MCPRegistrations table highlighted some bad unit tests - should be good now! |
|
Will let the tests pass, but also not merging until other problems are fixed |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6587 +/- ##
==========================================
+ Coverage 76.61% 76.66% +0.04%
==========================================
Files 398 398
Lines 20100 20103 +3
Branches 4839 4841 +2
==========================================
+ Hits 15400 15411 +11
+ Misses 4700 4692 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@hardillb the strictness of PG was overlooked (didnt like made up instance id Good to go now |
Description
Tests added
Related Issue(s)
closes #6586
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel