Skip to content

fix: correct overflow badge vertical alignment#39

Merged
javier-godoy merged 1 commit intomasterfrom
issue-38
Mar 30, 2026
Merged

fix: correct overflow badge vertical alignment#39
javier-godoy merged 1 commit intomasterfrom
issue-38

Conversation

@paodb
Copy link
Copy Markdown
Member

@paodb paodb commented Mar 26, 2026

Set line-height: 0 on vaadin-context-menu to eliminate the extra inline spacing that caused the overflow badge to appear misaligned relative to other badges in the list.

Close #38

Summary by CodeRabbit

  • Style
    • Improved context menu element rendering for better vertical spacing.

Set line-height: 0 on vaadin-context-menu to eliminate the extra inline spacing that caused the overflow badge to appear misaligned relative to other badges in the list.

Close #38
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 37effd3e-5258-4d74-9367-f3478dafdaaf

📥 Commits

Reviewing files that changed from the base of the PR and between 01843a4 and a7f1707.

📒 Files selected for processing (1)
  • src/main/resources/META-INF/resources/frontend/src/fc-badge-list.ts

Walkthrough

A CSS style rule was added to the BadgeList component that targets the vaadin-context-menu element and sets line-height to 0, addressing visual alignment of the overflow badge in the badge list component.

Changes

Cohort / File(s) Summary
BadgeList Component Styling
src/main/resources/META-INF/resources/frontend/src/fc-badge-list.ts
Added CSS rule targeting vaadin-context-menu with line-height: 0 to adjust vertical rendering of the overflow context menu.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • mlopezFC
  • javier-godoy
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding CSS to fix vertical alignment of the overflow badge, which is the primary objective of the pull request.
Linked Issues check ✅ Passed The code change directly addresses issue #38 by setting line-height: 0 on vaadin-context-menu to remove extra inline spacing causing the overflow badge misalignment.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to address the alignment issue; only a CSS rule was added to the BadgeList component with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-38

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@paodb paodb marked this pull request as ready for review March 26, 2026 23:41
@paodb paodb requested review from javier-godoy and mlopezFC March 26, 2026 23:41
@javier-godoy javier-godoy merged commit 48ce6ec into master Mar 30, 2026
5 checks passed
@javier-godoy javier-godoy deleted the issue-38 branch March 30, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overflow badge is slightly misaligned compared to other badges

2 participants