Scene-aware safe area#193
Merged
Merged
Conversation
## What changed - Added `UIWindowScene`-aware initializers to `FloatingDisplayController` and `FloatingDisplayTarget` - Propagated scene/window context into `SafeAreaFinder` - Replaced `SafeAreaFinder.shared` usage with owner-local finder instances - Scoped safe-area notifications to the originating finder instance to avoid cross-scene mixing - Preserved the existing initializer path with fallback behavior for backward compatibility ## Why - The original implementation assumed a single active app scene - `FloatingDisplayTarget` selected a foreground scene implicitly - safe-area lookup could resolve the wrong window because scene context was not passed through - this breaks multi-scene apps ## Context from the request - Pass the target scene into `FloatingDisplayController` initialization - Fix the logic that effectively behaved like a single-app assumption via `.foregroundActive` - Make safe-area resolution scene-aware without relying on a shared singleton instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.