fix(agent): lazy import @fastify/express to avoid requiring fastify #1381
+55
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users use Express, Koa, or other frameworks without Fastify, they were getting an error about missing 'fastify/lib/symbols' because @fastify/express was imported at the top level. This change makes the import lazy - @fastify/express is only imported when actually needed (when mounting on Fastify). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@fastify/expressimport lazy instead of top-levelProblem
When fastify is not installed (because the client uses Express, Koa, or another framework), the agent throws an error:
Solution
Use dynamic
import()for@fastify/expressonly when it's actually needed (whenmountOnFastifyis called).Test plan
🤖 Generated with Claude Code