Skip to content

Conversation

@Scra3
Copy link
Member

@Scra3 Scra3 commented Dec 24, 2025

Summary

  • Add mcp-server and agent-client packages to the CI test matrix
  • These packages were missing from the GitHub Actions workflow and their tests were not being run

Test plan

  • Verify packages have lint and test scripts
  • CI pipeline runs tests for both packages

🤖 Generated with Claude Code

@qltysh
Copy link

qltysh bot commented Dec 24, 2025

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on main by 0.42%.

Modified Files with Diff Coverage (29)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
packages/datasource-customizer/src/context/collection-context.ts100.0%
Coverage rating: A Coverage rating: A
packages/datasource-customizer/src/context/agent-context.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/action-field-enum.ts100.0%
New file Coverage rating: A
...ges/agent-client/src/action-fields/action-field-number-list.ts100.0%
New file Coverage rating: A
...es/agent-client/src/action-fields/action-field-color-picker.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/action-field-date.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/field-form-states.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/action-field-json.ts100.0%
New file Coverage rating: A
packages/mcp-server/src/tools/list.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/action-field-string.ts100.0%
New file Coverage rating: A
packages/agent-client/src/domains/collection.ts100.0%
New file Coverage rating: A
packages/mcp-server/src/forest-oauth-provider.ts0.0%409-410
New file Coverage rating: A
.../agent-client/src/action-fields/action-field-checkbox-group.ts100.0%
New file Coverage rating: A
packages/agent-client/src/domains/relation.ts100.0%
New file Coverage rating: A
packages/agent-client/src/http-requester.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/action-field-number.ts100.0%
New file Coverage rating: A
packages/mcp-server/src/tools/create.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/action-field-checkbox.ts100.0%
New file Coverage rating: A
packages/mcp-server/src/tools/describe-collection.ts100.0%
New file Coverage rating: A
packages/agent-client/src/domains/action.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-layout/action-layout-element.ts100.0%
New file Coverage rating: A
packages/agent-client/src/domains/remote-agent-client.ts100.0%
New file Coverage rating: A
...ges/agent-client/src/action-fields/action-field-string-list.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/action-field-dropdown.ts100.0%
New file Coverage rating: A
packages/agent-client/src/domains/segment.ts100.0%
New file Coverage rating: A
...ges/agent-client/src/action-fields/action-field-radio-group.ts100.0%
New file Coverage rating: A
packages/agent-client/src/action-fields/action-field.ts100.0%
New file Coverage rating: A
packages/mcp-server/src/tools/list-related.ts100.0%
New file Coverage rating: A
packages/mcp-server/src/utils/with-activity-log.ts100.0%
Total96.9%
🤖 Increase coverage with AI coding...

In the `ci/add-mcp-server-tests` branch, add test coverage for this new code:

- `packages/mcp-server/src/forest-oauth-provider.ts` -- Line 409-410

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@Scra3 Scra3 force-pushed the ci/add-mcp-server-tests branch from d528936 to 4d16056 Compare December 24, 2025 10:05
@qltysh
Copy link

qltysh bot commented Dec 24, 2025

2 new issues

Tool Category Rule Count
qlty Duplication Found 16 lines of similar code in 2 locations (mass = 104) 2

alban bertolini and others added 8 commits December 24, 2025 14:28
These packages were missing from the CI test matrix.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add missing tsconfig.eslint.json for agent-client package
- Fix server.test.ts env variable restoration (process.env cannot be
  reassigned wholesale - individual keys must be restored)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add braces after if conditions (curly rule)
- Fix unused TypeScript generics with eslint-disable comments
- Fix prettier formatting issues
- Fix import order in test file
- Convert done callbacks to Promise-based patterns (jest/no-done-callback)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Remove mcp-server from test matrix (has 43 pre-existing lint errors)
- Keep server.test.ts env restoration fix for when mcp-server is re-added
- Add comment explaining the temporary exclusion

The mcp-server package needs its lint errors fixed in a separate PR
before it can be added to CI.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Fix .js.js double extensions in mcp-server imports
- Add superagent to mcp-server devDependencies
- Fix _meta underscore dangle using destructuring
- Remove duplicate createJsonApiSchema helpers
- Fix revokeToken unused params with void expressions
- Remove unused TypingsSchema generics from agent-client classes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Remove the ESM-specific import/extensions rule override for mcp-server
to be consistent with other packages in the monorepo.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@VincentMolinie VincentMolinie force-pushed the ci/add-mcp-server-tests branch from d1ea7d8 to 8804975 Compare December 24, 2025 13:39
@VincentMolinie VincentMolinie merged commit f31a4d4 into main Dec 24, 2025
23 of 24 checks passed
@VincentMolinie VincentMolinie deleted the ci/add-mcp-server-tests branch December 24, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants