Conversation
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (5)
🛟 Help
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The BFF now answers a typed 422 instead of a misleading 503 when a multi-field sort targets a liana that can only sort on one field. refs PRD-1474
What
forest-express-sequelizeandforest-express-mongoose,sortwith more than one clause answers422 multi_field_sort_not_supported, before the list call. List and relation list.sortatmaxItems: 1on those agents and names the error.agent_unavailablemapping doesn't change.Why
sortas one column string. Express fails withUnknown column 'edge_composite_pk.seq,tenant_id'(500), and the BFF relayed it as503 agent_unavailable. Mongoose sorts on a field that doesn't exist and returns rows unsorted.sort[0]all fail on the liana itself (G0 on the ticket).How
sortable: falsefrom the apimap. It now also statesmultiFieldSort: false, keyed on the liana name the schema carries (a required argument, so no caller can drop the gate). The validator rejects on it, likefield_not_sortable.Verification
agent-bfftests,tsc --noEmit, eslint on484224e6d87a5e36b6484224e6d484224e6d(express, mongoose, rails, v2-ruby OAuth), A/B againstmainmulti_field_sort_not_supported, 0 list call on the agent (mongoose cold cache: only the capabilities 404 probe)maxItems: 1mainmain484224e6dLimits: the literal rails
[title,-created_at]case has unique titles, so key 2 can't be observed there (the 3 tied cases prove it). Mongoose relation list is not measurable: the bench schema has no relation. The relation-list integration test asserts onlyerror.type.Definition of Done
General
Security