fix(token-vault): replace substring URL matching with strict equality#580
Open
fix(token-vault): replace substring URL matching with strict equality#580
Conversation
Fixes a security vulnerability where evaluateUrlForInterception used .includes() for URL matching, allowing allow-list bypass via query parameter injection (e.g. https://evil.com?https://valid.com). Replaces .includes() with === for exact string comparison. Blob URLs now require explicit wildcard patterns (blob:https://origin/*). Also removes @forgerock/token-vault from changeset ignore list to enable re-release.
🦋 Changeset detectedLatest commit: 168c723 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 168c723
☁️ Nx Cloud last updated this comment at |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #580 +/- ##
============================================
- Coverage 57.14% 28.52% -28.63%
============================================
Files 105 11 -94
Lines 31752 1490 -30262
Branches 1800 49 -1751
============================================
- Hits 18145 425 -17720
+ Misses 13607 1065 -12542 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://pingidentity.atlassian.net/browse/SDKS-4732
Summary
evaluateUrlForInterceptionwhere.includes()allowed URL allow-list bypass via query parameter injection (e.g.https://evil.com?https://valid.comwould matchhttps://valid.com).includes()with===for exact string comparison@forgerock/token-vaultfrom changeset ignore list to enable re-releaseTest plan
blob:wildcard patternsblob:https://origin/*patterns