Skip to content

chore(release): 1.1.0-rc.0 - #71

Open
tsdamas wants to merge 12 commits into
mainfrom
1.1.0-rc.0
Open

tsdamas wants to merge 12 commits into
mainfrom
1.1.0-rc.0

Conversation

@tsdamas

@tsdamas tsdamas commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@tsdamas tsdamas added the wip Working in progress, do not review. label Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d73442c7-7f6c-4bbe-ae0e-a07807818be2


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.09%. Comparing base (b61a748) to head (c4a741b).

❌ Your project check has failed because the head coverage (71.09%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #71   +/-   ##
=========================================
  Coverage     71.09%   71.09%           
  Complexity      239      239           
=========================================
  Files           209      209           
  Lines         24592    24592           
  Branches       1175     1175           
=========================================
  Hits          17483    17483           
  Misses         6937     6937           
  Partials        172      172           
Flag Coverage Δ
android 16.04% <ø> (ø)
ios 80.97% <ø> (ø)
javascript 70.48% <ø> (ø)
Components Coverage Δ
Bridge glue 51.51% <ø> (ø)
Pure logic 80.86% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61a748...c4a741b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://ForgeRock.github.io/ping-react-native-sdk/docs-preview/pr-71/

Built to branch gh-pages at 2026-09-18 17:39 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@tsdamas tsdamas changed the title chore(release): 1.1.0-rc.0 defect fixes chore(release): 1.1.0-rc.0 Sep 16, 2026
Comment thread PingTestRunner/ios/PingTestRunner/AppDelegate.swift
/// store is cleared. HTTPCookieStorage and keychain deletion are synchronous;
/// WKWebsiteDataStore removal is asynchronous and gates the completion.
private static func clearAuthStorage(completion: @escaping () -> Void) {
HTTPCookieStorage.shared.removeCookies(since: Date.distantPast)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mend Code Security Check

New finding (1 of 1)

The Mend Code Security Check of your branch failed because of a Insecure Data Storage finding in this line.

SeverityVulnerability TypeCWEFileData FlowsDetected
MediumInsecure Data Storage

CWE-200

AppDelegate.swift:73

12026-09-16 11:48pm
Vulnerable Code

/// Wipes cookie stores and keychain items, invoking `completion` after every
/// store is cleared. HTTPCookieStorage and keychain deletion are synchronous;
/// WKWebsiteDataStore removal is asynchronous and gates the completion.
private static func clearAuthStorage(completion: @escaping () -> Void) {
HTTPCookieStorage.shared.removeCookies(since: Date.distantPast)

1 Data Flow/s detected

HTTPCookieStorage.shared.removeCookies(since: Date.distantPast)

Secure Code Warrior Training Material

● Training

   ▪ Secure Code Warrior Insecure Data Storage Training

● Videos

   ▪ Secure Code Warrior Insecure Data Storage Video 1

   ▪ Secure Code Warrior Insecure Data Storage Video 2

● Further Reading

   ▪ OWASP Top Ten 2017 A3: Sensitive Data Exposure

   ▪ OWASP Top Ten Proactive Controls 2018 C8: Protect Data Everywhere

   ▪ OWASP Top Ten 2021 A02: Cryptographic Failures

Suppress Finding

To suppress this finding as a acceptable risk, comment:

/mend code suppress acceptable-risk a59a72fc-d24f-4c17-845a-0548e972df84 Optional Comment

To suppress this finding as a false positive, comment:

/mend code suppress false-positive a59a72fc-d24f-4c17-845a-0548e972df84 Optional Comment
💬 Discuss Finding

Add context or questions for the security reviewer by commenting on this issue:

/mend comment Your Message

Your message will appear in the Mend Platform for the security team to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wip Working in progress, do not review.

Development

Successfully merging this pull request may close these issues.

1 participant