Add configASSERT to queue metadata accessor functions - #1467
Open
wanghengZzz wants to merge 1 commit into
Open
Conversation
uxQueueGetQueueNumber(), vQueueSetQueueNumber(), ucQueueGetQueueType(), uxQueueGetQueueItemSize(), and uxQueueGetQueueLength() dereference the queue handle without first checking that it is not NULL, unlike other public queue accessors such as uxQueueMessagesWaiting() and uxQueueSpacesAvailable(). This adds configASSERT( xQueue ) to each of these functions for consistency and to catch invalid handles in debug builds.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several queue.c accessor functions dereference
xQueuewithout firstvalidating it with
configASSERT, unlike comparable functions in thesame file (e.g.
uxQueueMessagesWaiting(),uxQueueSpacesAvailable()).This PR adds
configASSERT( xQueue )to:uxQueueGetQueueNumber()vQueueSetQueueNumber()ucQueueGetQueueType()uxQueueGetQueueItemSize()uxQueueGetQueueLength()This is a pure consistency fix with no behavioral change when
configASSERTis disabled (the default), and only adds a debug-timecheck when
configASSERTis enabled.Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.