[OPTIMIZATION] Remove unnecessary loop in Interp#assignValue#451
Open
NotHyper-474 wants to merge 1 commit into
Open
[OPTIMIZATION] Remove unnecessary loop in Interp#assignValue#451NotHyper-474 wants to merge 1 commit into
Interp#assignValue#451NotHyper-474 wants to merge 1 commit into
Conversation
NotHyper-474
changed the title
Interp#assignValueInterp#assignValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #337
Not sure why it's iterating through the imports to see if the class name matches the identifier in the context, considering the keys for the imports are already the names, which means we can just do a quick map lookup.
Tested with assigning to
Constants.TITLEand it still errored, which means it should still work.