feat(mobile-web): add session search, rename, and delete#840
Open
jarvis24young wants to merge 2 commits into
Open
feat(mobile-web): add session search, rename, and delete#840jarvis24young wants to merge 2 commits into
jarvis24young wants to merge 2 commits into
Conversation
- Search bar filters sessions client-side by name in real-time - Long-press on any session card opens a bottom-sheet context menu with Rename and Delete actions (also prevents browser context menu) - Rename opens a modal with text input pre-filled with current name; sends update_session_title command to desktop and updates store - Delete shows a confirmation dialog; calls delete_session on desktop and removes the session + cached messages from the Zustand store - Action toast provides transient success/failure feedback
- Replace hardcoded English search-empty string with i18n key - Clear previous toast timer on consecutive calls to prevent overlap - Clean up toast and long-press timers on component unmount - Add Escape/Enter keyboard support to delete confirmation dialog - Add role="alert" aria-live="assertive" to action toast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_session_titlebackend command)delete_sessionbackend command, removes session + cached messages from store)Design decisions
useMobileStore.getState()in callbacks to avoid stale closuresremoveSessionalso cleans upmessagesBySessionto prevent memory leaksTest plan