Skip to content

CI: Fix the DVC Diff workflow for non-main PR base branches#4624

Merged
seisman merged 1 commit intoGenericMappingTools:mainfrom
seisman:codex/dvc-diff-base-ref
May 6, 2026
Merged

CI: Fix the DVC Diff workflow for non-main PR base branches#4624
seisman merged 1 commit intoGenericMappingTools:mainfrom
seisman:codex/dvc-diff-base-ref

Conversation

@seisman
Copy link
Copy Markdown
Member

@seisman seisman commented May 6, 2026

The DVC Diff workflow always checks against the main branch, which doesn't work for PRs whose base branch is not the main branch, like #4623.

This PR fixes the issue. It works as expected as can be seen in the commit history in #4623.

@seisman seisman changed the title Fix DVC diff workflow for non-main PR base branches CI: Fix the DVC Diff workflow for non-main PR base branches May 6, 2026
@seisman seisman added bug Something isn't working maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels May 6, 2026
@seisman seisman added this to the 0.19.0 milestone May 6, 2026
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label May 6, 2026
@seisman seisman merged commit 2f61d38 into GenericMappingTools:main May 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants