Skip to content

feat(AABBTree): generic intersection search method#1154

Merged
BotellaA merged 4 commits into
Geode-solutions:generic-search-in-aabbtreefrom
yo35:generic-search-in-aabbtree
Jul 9, 2025
Merged

feat(AABBTree): generic intersection search method#1154
BotellaA merged 4 commits into
Geode-solutions:generic-search-in-aabbtreefrom
yo35:generic-search-in-aabbtree

Conversation

@yo35

@yo35 yo35 commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@yo35

yo35 commented Jun 20, 2025

Copy link
Copy Markdown
Contributor Author

The main purpose is to allow searching intersections against a geometric object, beyond those natively supported by OpenGeode (segment, ray, triangle...). That would be a planar rectangle or polygon living in a 3D space in my case.

The new method could also be used to factorize some code in the AABBTree implementation (compute_line_element_bbox(..), compute_triangle_element_bbox(..)...). Not achieved currently in the PR, but could be added.

@yo35

yo35 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

@BotellaA @panquez Any news regarding this PR? (I'm available this week for discussion if necessary)

@BotellaA

BotellaA commented Jul 8, 2025

Copy link
Copy Markdown
Member

I forgot about it.. Can you implement a unit test?

@yo35

yo35 commented Jul 8, 2025

Copy link
Copy Markdown
Contributor Author

I can implement a dedicated unit test. I can also re-implement AABBTree::compute_ray_element_bbox_intersection(..) using the new function, so that it will be covered by the existing test.

@yo35

yo35 commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

@BotellaA Now the existing queries following the pattern "compute intersection external object vs tree" are implemented using the generic one. The generic query is covered by the tests of the existing queries.

@BotellaA BotellaA changed the base branch from master to generic-search-in-aabbtree July 9, 2025 11:48
@BotellaA BotellaA merged commit a1a90e6 into Geode-solutions:generic-search-in-aabbtree Jul 9, 2025
4 of 5 checks passed
@BotellaA

Copy link
Copy Markdown
Member

🎉 This PR is included in version 15.22.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

Copy link
Copy Markdown
Member

🎉 This PR is included in version 15.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@yo35 yo35 deleted the generic-search-in-aabbtree branch September 30, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants