Skip to content

feat(AABBTree): allow non-parallel search queries#1206

Merged
BotellaA merged 2 commits into
Geode-solutions:fix/aabb-non-parafrom
yo35:non-parallel-aabb-tree
Nov 3, 2025
Merged

feat(AABBTree): allow non-parallel search queries#1206
BotellaA merged 2 commits into
Geode-solutions:fix/aabb-non-parafrom
yo35:non-parallel-aabb-tree

Conversation

@yo35

@yo35 yo35 commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@BotellaA

Copy link
Copy Markdown
Member

Can you explain why do you need this?

@yo35

yo35 commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

Sometimes, it might be useful to be able to execute search queries without parallelization (e.g. if called from a code section that is already parallelized).

@yo35

yo35 commented Oct 31, 2025

Copy link
Copy Markdown
Contributor Author

@BotellaA Crossed comments ;-) . The use case is to execute the query from a code section that is already parallelized.

@BotellaA

BotellaA commented Nov 3, 2025

Copy link
Copy Markdown
Member

Here is another implementation proposal that limits ABI breaks:

  • add a parallel_ member to AABB::Impl with a default value of true
  • add a setter AABB::set_parallel(bool)

This way, you can change the behavior with global options without changing the API for every query.

@BotellaA BotellaA changed the base branch from master to fix/aabb-non-para November 3, 2025 15:13
@BotellaA BotellaA merged commit f088874 into Geode-solutions:fix/aabb-non-para Nov 3, 2025
4 of 5 checks passed
@BotellaA

BotellaA commented Nov 3, 2025

Copy link
Copy Markdown
Member

🎉 This PR is included in version 15.30.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BotellaA

BotellaA commented Nov 5, 2025

Copy link
Copy Markdown
Member

🎉 This PR is included in version 15.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@yo35 yo35 deleted the non-parallel-aabb-tree branch May 22, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants